Re: [Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw

["Andreas Färber" <afaerber@suse.de>]

Am 30.03.2015 um 13:45 schrieb Paolo Bonzini:
> ioport.c is already able to split a 16-bit access into two 8-bit
> accesses to consecutive ports.  Tested with Epic Pinball.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/audio/sb16.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c
> index 444eb9e..b052de5 100644
> --- a/hw/audio/sb16.c
> +++ b/hw/audio/sb16.c
> @@ -1121,12 +1121,6 @@ static IO_WRITE_PROTO (mixer_write_datab)
>      s->mixer_regs[s->mixer_nreg] = val;
>  }
>  
> -static IO_WRITE_PROTO (mixer_write_indexw)
> -{
> -    mixer_write_indexb (opaque, nport, val & 0xff);
> -    mixer_write_datab (opaque, nport, (val >> 8) & 0xff);
> -}

I assume you've verified the endianness handling, too?

Reviewed-by: Andreas Färber <afaerber@suse.de>

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)