All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7790: add EtherAVB DT support
Date: Tue, 31 Mar 2015 15:04:43 +0000	[thread overview]
Message-ID: <551AB78B.4000506@cogentembedded.com> (raw)
In-Reply-To: <20150331002113.GB16289@verge.net.au>

Hello.

On 03/31/2015 03:21 AM, Simon Horman wrote:

>> Define the generic R8A7790 part of the EtherAVB device node.

> Please repost once this binding (and associated driver) has been accepted.

    OK, but will you merge patch #1?

>> Based on original patch by Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>>   arch/arm/boot/dts/r8a7790.dtsi |   10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7790.dtsi
>> =================================>> --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -626,6 +626,16 @@
>>   		status = "disabled";
>>   	};
>>
>> +	avb: ethernet@e6800000 {
>> +		compatible = "renesas,ravb-r8a7790";

    I went the usual way here but I suspect that SoC part of the prop should 
be "-rcar-gen2" as we now have this IP core (as well as most of the others, 
except PFC) described in a common manual for the R-Car generation 2 SoCs.
What do you think?

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: shmobile: r8a7790: add EtherAVB DT support
Date: Tue, 31 Mar 2015 18:04:43 +0300	[thread overview]
Message-ID: <551AB78B.4000506@cogentembedded.com> (raw)
In-Reply-To: <20150331002113.GB16289@verge.net.au>

Hello.

On 03/31/2015 03:21 AM, Simon Horman wrote:

>> Define the generic R8A7790 part of the EtherAVB device node.

> Please repost once this binding (and associated driver) has been accepted.

    OK, but will you merge patch #1?

>> Based on original patch by Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>>   arch/arm/boot/dts/r8a7790.dtsi |   10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7790.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -626,6 +626,16 @@
>>   		status = "disabled";
>>   	};
>>
>> +	avb: ethernet at e6800000 {
>> +		compatible = "renesas,ravb-r8a7790";

    I went the usual way here but I suspect that SoC part of the prop should 
be "-rcar-gen2" as we now have this IP core (as well as most of the others, 
except PFC) described in a common manual for the R-Car generation 2 SoCs.
What do you think?

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-sh@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, devicetree@vger.kernel.org,
	magnus.damm@gmail.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7790: add EtherAVB DT support
Date: Tue, 31 Mar 2015 18:04:43 +0300	[thread overview]
Message-ID: <551AB78B.4000506@cogentembedded.com> (raw)
In-Reply-To: <20150331002113.GB16289@verge.net.au>

Hello.

On 03/31/2015 03:21 AM, Simon Horman wrote:

>> Define the generic R8A7790 part of the EtherAVB device node.

> Please repost once this binding (and associated driver) has been accepted.

    OK, but will you merge patch #1?

>> Based on original patch by Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>>   arch/arm/boot/dts/r8a7790.dtsi |   10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7790.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -626,6 +626,16 @@
>>   		status = "disabled";
>>   	};
>>
>> +	avb: ethernet@e6800000 {
>> +		compatible = "renesas,ravb-r8a7790";

    I went the usual way here but I suspect that SoC part of the prop should 
be "-rcar-gen2" as we now have this IP core (as well as most of the others, 
except PFC) described in a common manual for the R-Car generation 2 SoCs.
What do you think?

WBR, Sergei


  reply	other threads:[~2015-03-31 15:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 21:56 [PATCH 0/2] Add R8A7790 EtherAVB DT support Sergei Shtylyov
2015-03-30 21:56 ` Sergei Shtylyov
2015-03-30 21:56 ` Sergei Shtylyov
2015-03-30 21:58 ` [PATCH 1/2] ARM: shmobile: r8a7790: add EtherAVB clock Sergei Shtylyov
2015-03-30 21:58   ` Sergei Shtylyov
2015-03-30 21:58   ` Sergei Shtylyov
2015-04-02  7:59   ` Geert Uytterhoeven
2015-04-02  7:59     ` Geert Uytterhoeven
2015-04-02  7:59     ` Geert Uytterhoeven
2015-03-30 21:59 ` [PATCH 2/2] ARM: shmobile: r8a7790: add EtherAVB DT support Sergei Shtylyov
2015-03-30 21:59   ` Sergei Shtylyov
2015-03-30 21:59   ` Sergei Shtylyov
2015-03-31  0:21   ` Simon Horman
2015-03-31  0:21     ` Simon Horman
2015-03-31  0:21     ` Simon Horman
2015-03-31 15:04     ` Sergei Shtylyov [this message]
2015-03-31 15:04       ` Sergei Shtylyov
2015-03-31 15:04       ` Sergei Shtylyov
2015-04-02  1:33       ` Simon Horman
2015-04-02  1:33         ` Simon Horman
2015-04-02  1:33         ` Simon Horman
2015-04-02 11:31         ` Sergei Shtylyov
2015-04-02 11:31           ` Sergei Shtylyov
2015-04-02 11:31           ` Sergei Shtylyov
2015-04-06  1:09           ` Simon Horman
2015-04-06  1:09             ` Simon Horman
2015-04-06  1:09             ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551AB78B.4000506@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.