From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core
Date: Tue, 31 Mar 2015 21:30:50 +0530 [thread overview]
Message-ID: <551AC4B2.4090609@ti.com> (raw)
In-Reply-To: <20150326230707.GB18887@dtor-ws>
On Friday 27 March 2015 04:37 AM, Dmitry Torokhov wrote:
> On Wed, Mar 25, 2015 at 05:04:32PM -0700, Arun Ramamurthy wrote:
>>
>>
>> On 15-03-25 03:03 PM, Kishon Vijay Abraham I wrote:
>>> Hi,
>>>
>>> On Saturday 21 March 2015 02:59 AM, Arun Ramamurthy wrote:
>>>>
>>>>
>>>> On 15-03-20 02:26 PM, Dmitry Torokhov wrote:
>>>>> Hi Arun,
>>>>>
>>>>> On Fri, Mar 20, 2015 at 02:07:08PM -0700, Arun Ramamurthy wrote:
>>>>>> Adding devm_of_phy_get_by_index to get phys by supplying an index
>>>>>> and not a phy name when multiple phys are declared
>>>
>>> I think a bit more explanation on why get_by_index is needed here.
>> Thanks Kison. Can you be more specific? I am unsure of what more I
>> can explain here.
>
> We just need to mention that some generic drivers, such as ehci, may use
> multiple phys, and for such drivers referencing phy(s) by name(s) does
> not make sense. Instead of inventing elaborate naming schemes and
> producing custom code to iterate over names, such drivers are better of
> using nameless phy bindings and using this newly introduced API to
> iterate through them.
+1
-Kishon
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Dmitry Torokhov <dtor@google.com>,
Arun Ramamurthy <arun.ramamurthy@broadcom.com>
Cc: Tony Prisk <linux@prisktech.co.nz>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, Anatol Pomazau <anatol@google.com>,
Jonathan Richardson <jonathar@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core
Date: Tue, 31 Mar 2015 21:30:50 +0530 [thread overview]
Message-ID: <551AC4B2.4090609@ti.com> (raw)
In-Reply-To: <20150326230707.GB18887@dtor-ws>
On Friday 27 March 2015 04:37 AM, Dmitry Torokhov wrote:
> On Wed, Mar 25, 2015 at 05:04:32PM -0700, Arun Ramamurthy wrote:
>>
>>
>> On 15-03-25 03:03 PM, Kishon Vijay Abraham I wrote:
>>> Hi,
>>>
>>> On Saturday 21 March 2015 02:59 AM, Arun Ramamurthy wrote:
>>>>
>>>>
>>>> On 15-03-20 02:26 PM, Dmitry Torokhov wrote:
>>>>> Hi Arun,
>>>>>
>>>>> On Fri, Mar 20, 2015 at 02:07:08PM -0700, Arun Ramamurthy wrote:
>>>>>> Adding devm_of_phy_get_by_index to get phys by supplying an index
>>>>>> and not a phy name when multiple phys are declared
>>>
>>> I think a bit more explanation on why get_by_index is needed here.
>> Thanks Kison. Can you be more specific? I am unsure of what more I
>> can explain here.
>
> We just need to mention that some generic drivers, such as ehci, may use
> multiple phys, and for such drivers referencing phy(s) by name(s) does
> not make sense. Instead of inventing elaborate naming schemes and
> producing custom code to iterate over names, such drivers are better of
> using nameless phy bindings and using this newly introduced API to
> iterate through them.
+1
-Kishon
next prev parent reply other threads:[~2015-03-31 16:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 21:07 [PATCH 0/3] Add devm_of_phy_get_by_index and update platform drivers Arun Ramamurthy
2015-03-20 21:07 ` Arun Ramamurthy
2015-03-20 21:07 ` [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core Arun Ramamurthy
2015-03-20 21:07 ` Arun Ramamurthy
2015-03-20 21:26 ` Dmitry Torokhov
2015-03-20 21:26 ` Dmitry Torokhov
2015-03-20 21:29 ` Arun Ramamurthy
2015-03-20 21:29 ` Arun Ramamurthy
2015-03-25 22:03 ` Kishon Vijay Abraham I
2015-03-25 22:03 ` Kishon Vijay Abraham I
2015-03-26 0:04 ` Arun Ramamurthy
2015-03-26 0:04 ` Arun Ramamurthy
2015-03-26 23:07 ` Dmitry Torokhov
2015-03-26 23:07 ` Dmitry Torokhov
2015-03-31 16:00 ` Kishon Vijay Abraham I [this message]
2015-03-31 16:00 ` Kishon Vijay Abraham I
2015-03-20 21:07 ` [PATCH 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index Arun Ramamurthy
2015-03-20 21:07 ` Arun Ramamurthy
2015-03-20 21:40 ` Dmitry Torokhov
2015-03-20 21:40 ` Dmitry Torokhov
2015-03-20 21:07 ` [PATCH 3/3] usb: ohci-platform: " Arun Ramamurthy
2015-03-20 21:07 ` Arun Ramamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AC4B2.4090609@ti.com \
--to=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.