From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Justin Ossevoort <justin@quarantainenet.nl>,
qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim
Date: Tue, 31 Mar 2015 11:03:27 -0600 [thread overview]
Message-ID: <551AD35F.2020509@redhat.com> (raw)
In-Reply-To: <551AD0C9.6080507@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
On 03/31/2015 10:52 AM, Paolo Bonzini wrote:
>> -# Returns: Nothing.
>> +# Returns: Number of bytes trimmed by this call.
>
> It's better to add "(since 2.4)" here.
>
> Apart from this, looks good.
Changing a "return":{} to "return":0 is not backwards-compatible.
>
> I'm CCing the qemu-ga maintainer.
I failed to do that in my beefier reply, so I'm responding here just to
say that this needs a v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-31 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 15:14 [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim Justin Ossevoort
2015-03-31 16:52 ` Paolo Bonzini
2015-03-31 17:03 ` Eric Blake [this message]
2015-04-01 7:54 ` Paolo Bonzini
2015-04-01 12:33 ` Eric Blake
2015-04-01 16:49 ` Paolo Bonzini
2015-04-02 7:37 ` Justin Ossevoort
2015-03-31 17:01 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AD35F.2020509@redhat.com \
--to=eblake@redhat.com \
--cc=justin@quarantainenet.nl \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.