From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] balloon: improve error msg when adding second device
Date: Tue, 31 Mar 2015 12:20:01 -0600 [thread overview]
Message-ID: <551AE551.90402@redhat.com> (raw)
In-Reply-To: <20150331133251.5be10dd6@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On 03/31/2015 11:32 AM, Luiz Capitulino wrote:
> A VM supports only one balloon device, but due to several changes
> in infrastructure the error message got messed up when trying
> to add a second device. Fix it.
>
> Before this fix
>
> After this fix
[nice comparison snipped]
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>
> I think this can go through in via -trivial. I also think this
> is so simple and useful that it could be merged during freeze.
>
> balloon.c | 1 -
> hw/virtio/virtio-balloon.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] balloon: improve error msg when adding second device
Date: Tue, 31 Mar 2015 12:20:01 -0600 [thread overview]
Message-ID: <551AE551.90402@redhat.com> (raw)
In-Reply-To: <20150331133251.5be10dd6@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On 03/31/2015 11:32 AM, Luiz Capitulino wrote:
> A VM supports only one balloon device, but due to several changes
> in infrastructure the error message got messed up when trying
> to add a second device. Fix it.
>
> Before this fix
>
> After this fix
[nice comparison snipped]
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>
> I think this can go through in via -trivial. I also think this
> is so simple and useful that it could be merged during freeze.
>
> balloon.c | 1 -
> hw/virtio/virtio-balloon.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-31 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 17:32 [Qemu-trivial] [PATCH] balloon: improve error msg when adding second device Luiz Capitulino
2015-03-31 17:32 ` [Qemu-devel] " Luiz Capitulino
2015-03-31 18:20 ` Eric Blake [this message]
2015-03-31 18:20 ` Eric Blake
2015-04-25 6:12 ` [Qemu-trivial] " Michael Tokarev
2015-04-25 6:12 ` [Qemu-devel] " Michael Tokarev
2015-04-25 14:30 ` [Qemu-trivial] " Luiz Capitulino
2015-04-25 14:30 ` [Qemu-devel] " Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AE551.90402@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.