* [PATCH 0/1] ARM: dts: sun5i: Enable touchscreen on Utoo P66 @ 2015-03-29 18:13 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2015-03-29 18:13 UTC (permalink / raw) To: linux-arm-kernel Hi Maxime, The driver for the chipone icn8318 touchscreen found on the Utoo P66 tablet has been queued up by Dmitry for merging into 4.1 : https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/drivers/input?h=next&id=a93ad65d37 Can you please add this patch to your dts tree for 4.1 ? Thanks & Regards, Hans ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/1] ARM: dts: sun5i: Enable touchscreen on Utoo P66 @ 2015-03-29 18:13 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2015-03-29 18:13 UTC (permalink / raw) To: Maxime Ripard Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw Hi Maxime, The driver for the chipone icn8318 touchscreen found on the Utoo P66 tablet has been queued up by Dmitry for merging into 4.1 : https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/drivers/input?h=next&id=a93ad65d37 Can you please add this patch to your dts tree for 4.1 ? Thanks & Regards, Hans ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: sun5i: Enable touchscreen on Utoo P66 @ 2015-03-29 18:13 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2015-03-29 18:13 UTC (permalink / raw) To: linux-arm-kernel Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts index 0f0a411..d1d4d30 100644 --- a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +++ b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts @@ -50,6 +50,7 @@ #include "sunxi-common-regulators.dtsi" #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/pinctrl/sun4i-a10.h> / { @@ -93,6 +94,20 @@ pinctrl-0 = <&i2c1_pins_a>; status = "okay"; + chipone_icn8318 at 40 { + compatible = "chipone,icn8318"; + reg = <0x40>; + interrupt-parent = <&pio>; + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */ + pinctrl-names = "default"; + pinctrl-0 = <&ts_wake_pin_p66>; + wake-gpios = <&pio 1 3 GPIO_ACTIVE_HIGH>; /* PB3 */ + touchscreen-size-x = <800>; + touchscreen-size-y = <480>; + touchscreen-inverted-x; + touchscreen-swapped-x-y; + }; + pcf8563: rtc at 51 { compatible = "nxp,pcf8563"; reg = <0x51>; @@ -152,6 +167,13 @@ allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; }; + ts_wake_pin_p66: ts_wake_pin at 0 { + allwinner,pins = "PB3"; + allwinner,function = "gpio_out"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; + }; + usb0_vbus_pin_a: usb0_vbus_pin at 0 { allwinner,pins = "PB4"; allwinner,function = "gpio_out"; -- 2.3.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: sun5i: Enable touchscreen on Utoo P66 @ 2015-03-29 18:13 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2015-03-29 18:13 UTC (permalink / raw) To: Maxime Ripard Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Hans de Goede Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet. Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> --- arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts index 0f0a411..d1d4d30 100644 --- a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +++ b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts @@ -50,6 +50,7 @@ #include "sunxi-common-regulators.dtsi" #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/pinctrl/sun4i-a10.h> / { @@ -93,6 +94,20 @@ pinctrl-0 = <&i2c1_pins_a>; status = "okay"; + chipone_icn8318@40 { + compatible = "chipone,icn8318"; + reg = <0x40>; + interrupt-parent = <&pio>; + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */ + pinctrl-names = "default"; + pinctrl-0 = <&ts_wake_pin_p66>; + wake-gpios = <&pio 1 3 GPIO_ACTIVE_HIGH>; /* PB3 */ + touchscreen-size-x = <800>; + touchscreen-size-y = <480>; + touchscreen-inverted-x; + touchscreen-swapped-x-y; + }; + pcf8563: rtc@51 { compatible = "nxp,pcf8563"; reg = <0x51>; @@ -152,6 +167,13 @@ allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; }; + ts_wake_pin_p66: ts_wake_pin@0 { + allwinner,pins = "PB3"; + allwinner,function = "gpio_out"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; + }; + usb0_vbus_pin_a: usb0_vbus_pin@0 { allwinner,pins = "PB4"; allwinner,function = "gpio_out"; -- 2.3.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: sun5i: Enable touchscreen on Utoo P66 @ 2015-03-30 22:52 ` Maxime Ripard 0 siblings, 0 replies; 8+ messages in thread From: Maxime Ripard @ 2015-03-30 22:52 UTC (permalink / raw) To: linux-arm-kernel Hi Hans, On Sun, Mar 29, 2015 at 08:13:51PM +0200, Hans de Goede wrote: > Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts > index 0f0a411..d1d4d30 100644 > --- a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts > +++ b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts > @@ -50,6 +50,7 @@ > #include "sunxi-common-regulators.dtsi" > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > +#include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/pinctrl/sun4i-a10.h> > > / { > @@ -93,6 +94,20 @@ > pinctrl-0 = <&i2c1_pins_a>; > status = "okay"; > > + chipone_icn8318 at 40 { The node name should be the class of the device, something like touchscreen at 40 in this case. > + compatible = "chipone,icn8318"; > + reg = <0x40>; > + interrupt-parent = <&pio>; > + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */ Shouldn't you reference this pin in the pinctrl node too? If this patch is resent soon enough, I'll merge it and send it through a late pull request together with the A23 SMP and A31 cpufreq patches. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150330/2466e79c/attachment.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: sun5i: Enable touchscreen on Utoo P66 @ 2015-03-30 22:52 ` Maxime Ripard 0 siblings, 0 replies; 8+ messages in thread From: Maxime Ripard @ 2015-03-30 22:52 UTC (permalink / raw) To: Hans de Goede Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 1508 bytes --] Hi Hans, On Sun, Mar 29, 2015 at 08:13:51PM +0200, Hans de Goede wrote: > Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet. > > Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > --- > arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts > index 0f0a411..d1d4d30 100644 > --- a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts > +++ b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts > @@ -50,6 +50,7 @@ > #include "sunxi-common-regulators.dtsi" > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > +#include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/pinctrl/sun4i-a10.h> > > / { > @@ -93,6 +94,20 @@ > pinctrl-0 = <&i2c1_pins_a>; > status = "okay"; > > + chipone_icn8318@40 { The node name should be the class of the device, something like touchscreen@40 in this case. > + compatible = "chipone,icn8318"; > + reg = <0x40>; > + interrupt-parent = <&pio>; > + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */ Shouldn't you reference this pin in the pinctrl node too? If this patch is resent soon enough, I'll merge it and send it through a late pull request together with the A23 SMP and A31 cpufreq patches. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [linux-sunxi] Re: [PATCH] ARM: dts: sun5i: Enable touchscreen on Utoo P66 2015-03-30 22:52 ` Maxime Ripard @ 2015-04-01 15:29 ` Hans de Goede -1 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2015-04-01 15:29 UTC (permalink / raw) To: linux-arm-kernel Hi, On 31-03-15 00:52, Maxime Ripard wrote: > Hi Hans, > > On Sun, Mar 29, 2015 at 08:13:51PM +0200, Hans de Goede wrote: >> Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts >> index 0f0a411..d1d4d30 100644 >> --- a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts >> +++ b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts >> @@ -50,6 +50,7 @@ >> #include "sunxi-common-regulators.dtsi" >> #include <dt-bindings/gpio/gpio.h> >> #include <dt-bindings/input/input.h> >> +#include <dt-bindings/interrupt-controller/irq.h> >> #include <dt-bindings/pinctrl/sun4i-a10.h> >> >> / { >> @@ -93,6 +94,20 @@ >> pinctrl-0 = <&i2c1_pins_a>; >> status = "okay"; >> >> + chipone_icn8318 at 40 { > > The node name should be the class of the device, something like > touchscreen at 40 in this case. Ok I'll do a v2 fixing this. >> + compatible = "chipone,icn8318"; >> + reg = <0x40>; >> + interrupt-parent = <&pio>; >> + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */ > > Shouldn't you reference this pin in the pinctrl node too? That is not necessary when specifying a gpio interrupt through the irq chip (rather then through a gpios property), the mux is automatically set to irq by the kernel when requesting the irq. Also note that we must use the interrupts notation here as this is specified by the i2c client bindings. None of the other boards using i2c + oob irq pins specifies a pinmux for the irq pin either. Regards, Hans ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [PATCH] ARM: dts: sun5i: Enable touchscreen on Utoo P66 @ 2015-04-01 15:29 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2015-04-01 15:29 UTC (permalink / raw) To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree Hi, On 31-03-15 00:52, Maxime Ripard wrote: > Hi Hans, > > On Sun, Mar 29, 2015 at 08:13:51PM +0200, Hans de Goede wrote: >> Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet. >> >> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >> --- >> arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts >> index 0f0a411..d1d4d30 100644 >> --- a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts >> +++ b/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts >> @@ -50,6 +50,7 @@ >> #include "sunxi-common-regulators.dtsi" >> #include <dt-bindings/gpio/gpio.h> >> #include <dt-bindings/input/input.h> >> +#include <dt-bindings/interrupt-controller/irq.h> >> #include <dt-bindings/pinctrl/sun4i-a10.h> >> >> / { >> @@ -93,6 +94,20 @@ >> pinctrl-0 = <&i2c1_pins_a>; >> status = "okay"; >> >> + chipone_icn8318@40 { > > The node name should be the class of the device, something like > touchscreen@40 in this case. Ok I'll do a v2 fixing this. >> + compatible = "chipone,icn8318"; >> + reg = <0x40>; >> + interrupt-parent = <&pio>; >> + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */ > > Shouldn't you reference this pin in the pinctrl node too? That is not necessary when specifying a gpio interrupt through the irq chip (rather then through a gpios property), the mux is automatically set to irq by the kernel when requesting the irq. Also note that we must use the interrupts notation here as this is specified by the i2c client bindings. None of the other boards using i2c + oob irq pins specifies a pinmux for the irq pin either. Regards, Hans ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-04-01 15:29 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-29 18:13 [PATCH 0/1] ARM: dts: sun5i: Enable touchscreen on Utoo P66 Hans de Goede 2015-03-29 18:13 ` Hans de Goede 2015-03-29 18:13 ` [PATCH] " Hans de Goede 2015-03-29 18:13 ` Hans de Goede 2015-03-30 22:52 ` Maxime Ripard 2015-03-30 22:52 ` Maxime Ripard 2015-04-01 15:29 ` [linux-sunxi] " Hans de Goede 2015-04-01 15:29 ` Hans de Goede
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.