From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, Ed Maste <emaste@freebsd.org>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] qtest: Add assertion that required environment variable is set
Date: Wed, 01 Apr 2015 23:14:23 +0200 [thread overview]
Message-ID: <551C5FAF.7010303@redhat.com> (raw)
In-Reply-To: <551C5DE7.70904@redhat.com>
On 01/04/2015 23:06, John Snow wrote:
>
> if (qemu == NULL) {
> fprintf(stderr, "...");
> g_assert_not_reached();
> }
>
> Though that does read a little strangely. ("Here's a nice error message
> for something we are asserting will never happen.")
Just "exit(1);" then. :)
Good idea, this is annoying.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, Ed Maste <emaste@freebsd.org>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set
Date: Wed, 01 Apr 2015 23:14:23 +0200 [thread overview]
Message-ID: <551C5FAF.7010303@redhat.com> (raw)
In-Reply-To: <551C5DE7.70904@redhat.com>
On 01/04/2015 23:06, John Snow wrote:
>
> if (qemu == NULL) {
> fprintf(stderr, "...");
> g_assert_not_reached();
> }
>
> Though that does read a little strangely. ("Here's a nice error message
> for something we are asserting will never happen.")
Just "exit(1);" then. :)
Good idea, this is annoying.
Paolo
next prev parent reply other threads:[~2015-04-01 21:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 18:00 [Qemu-trivial] [PATCH] qtest: Add assertion that required environment variable is set Ed Maste
2015-04-01 18:00 ` [Qemu-devel] " Ed Maste
2015-04-01 21:06 ` [Qemu-trivial] " John Snow
2015-04-01 21:06 ` John Snow
2015-04-01 21:14 ` Paolo Bonzini [this message]
2015-04-01 21:14 ` Paolo Bonzini
2015-04-01 22:45 ` [Qemu-trivial] " Peter Maydell
2015-04-01 22:45 ` Peter Maydell
2015-04-02 19:31 ` [Qemu-trivial] " Ed Maste
2015-04-02 19:31 ` Ed Maste
2015-04-03 11:18 ` [Qemu-trivial] " Peter Maydell
2015-04-03 11:18 ` Peter Maydell
2015-04-06 17:46 ` [Qemu-trivial] " John Snow
2015-04-06 17:46 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551C5FAF.7010303@redhat.com \
--to=pbonzini@redhat.com \
--cc=emaste@freebsd.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.