* [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
@ 2015-04-01 17:58 ` Ed Maste
0 siblings, 0 replies; 10+ messages in thread
From: Ed Maste @ 2015-04-01 17:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Ed Maste
On BSDs "make" is typically BSD make, while "gmake" is GNU make.
Signed-off-by: Ed Maste <emaste@freebsd.org>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 88bce56..ee40397 100644
--- a/Makefile
+++ b/Makefile
@@ -331,8 +331,8 @@ distclean: clean
rm -rf $$d || exit 1 ; \
done
rm -Rf .sdk
- if test -f pixman/config.log; then make -C pixman distclean; fi
- if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
+ if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
+ if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
ar de en-us fi fr-be hr it lv nl pl ru th \
--
2.2.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
2015-04-01 17:58 ` [Qemu-devel] " Ed Maste
@ 2015-04-01 18:45 ` Stefan Weil
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2015-04-01 18:45 UTC (permalink / raw)
To: Ed Maste, qemu-devel; +Cc: qemu-trivial
Am 01.04.2015 um 19:58 schrieb Ed Maste:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 88bce56..ee40397 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,8 @@ distclean: clean
> rm -rf $$d || exit 1 ; \
> done
> rm -Rf .sdk
> - if test -f pixman/config.log; then make -C pixman distclean; fi
> - if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> + if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> + if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
>
> KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
> ar de en-us fi fr-be hr it lv nl pl ru th \
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
@ 2015-04-01 18:45 ` Stefan Weil
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2015-04-01 18:45 UTC (permalink / raw)
To: Ed Maste, qemu-devel; +Cc: qemu-trivial
Am 01.04.2015 um 19:58 schrieb Ed Maste:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 88bce56..ee40397 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,8 @@ distclean: clean
> rm -rf $$d || exit 1 ; \
> done
> rm -Rf .sdk
> - if test -f pixman/config.log; then make -C pixman distclean; fi
> - if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> + if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> + if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
>
> KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
> ar de en-us fi fr-be hr it lv nl pl ru th \
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
2015-04-01 18:45 ` Stefan Weil
@ 2015-04-02 3:16 ` Fam Zheng
-1 siblings, 0 replies; 10+ messages in thread
From: Fam Zheng @ 2015-04-02 3:16 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Wed, 04/01 20:45, Stefan Weil wrote:
> Am 01.04.2015 um 19:58 schrieb Ed Maste:
> >On BSDs "make" is typically BSD make, while "gmake" is GNU make.
> >
> >Signed-off-by: Ed Maste <emaste@freebsd.org>
> >---
> > Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/Makefile b/Makefile
> >index 88bce56..ee40397 100644
> >--- a/Makefile
> >+++ b/Makefile
> >@@ -331,8 +331,8 @@ distclean: clean
> > rm -rf $$d || exit 1 ; \
> > done
> > rm -Rf .sdk
> >- if test -f pixman/config.log; then make -C pixman distclean; fi
> >- if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> >+ if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> >+ if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
> > KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
> > ar de en-us fi fr-be hr it lv nl pl ru th \
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
>
One more occasion below:
$(INSTALLER): $(SRC_PATH)/qemu.nsi
make install prefix=${INSTDIR}
But this is already helpful:
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
@ 2015-04-02 3:16 ` Fam Zheng
0 siblings, 0 replies; 10+ messages in thread
From: Fam Zheng @ 2015-04-02 3:16 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Ed Maste, qemu-devel
On Wed, 04/01 20:45, Stefan Weil wrote:
> Am 01.04.2015 um 19:58 schrieb Ed Maste:
> >On BSDs "make" is typically BSD make, while "gmake" is GNU make.
> >
> >Signed-off-by: Ed Maste <emaste@freebsd.org>
> >---
> > Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/Makefile b/Makefile
> >index 88bce56..ee40397 100644
> >--- a/Makefile
> >+++ b/Makefile
> >@@ -331,8 +331,8 @@ distclean: clean
> > rm -rf $$d || exit 1 ; \
> > done
> > rm -Rf .sdk
> >- if test -f pixman/config.log; then make -C pixman distclean; fi
> >- if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> >+ if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> >+ if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
> > KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
> > ar de en-us fi fr-be hr it lv nl pl ru th \
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
>
One more occasion below:
$(INSTALLER): $(SRC_PATH)/qemu.nsi
make install prefix=${INSTDIR}
But this is already helpful:
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
2015-04-01 17:58 ` [Qemu-devel] " Ed Maste
@ 2015-04-02 8:58 ` Stefan Hajnoczi
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2015-04-02 8:58 UTC (permalink / raw)
To: Ed Maste; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
On Wed, Apr 01, 2015 at 01:58:38PM -0400, Ed Maste wrote:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Same on Solaris, if I remember correctly.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
@ 2015-04-02 8:58 ` Stefan Hajnoczi
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2015-04-02 8:58 UTC (permalink / raw)
To: Ed Maste; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
On Wed, Apr 01, 2015 at 01:58:38PM -0400, Ed Maste wrote:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Same on Solaris, if I remember correctly.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] Use $(MAKE) for recursive make
2015-04-01 17:58 ` [Qemu-devel] " Ed Maste
@ 2015-04-02 13:56 ` Paolo Bonzini
-1 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2015-04-02 13:56 UTC (permalink / raw)
To: Ed Maste, qemu-devel; +Cc: qemu-trivial
On 01/04/2015 19:58, Ed Maste wrote:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 88bce56..ee40397 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,8 @@ distclean: clean
> rm -rf $$d || exit 1 ; \
> done
> rm -Rf .sdk
> - if test -f pixman/config.log; then make -C pixman distclean; fi
> - if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> + if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> + if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
>
> KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
> ar de en-us fi fr-be hr it lv nl pl ru th \
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] Use $(MAKE) for recursive make
@ 2015-04-02 13:56 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2015-04-02 13:56 UTC (permalink / raw)
To: Ed Maste, qemu-devel; +Cc: qemu-trivial
On 01/04/2015 19:58, Ed Maste wrote:
> On BSDs "make" is typically BSD make, while "gmake" is GNU make.
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 88bce56..ee40397 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,8 @@ distclean: clean
> rm -rf $$d || exit 1 ; \
> done
> rm -Rf .sdk
> - if test -f pixman/config.log; then make -C pixman distclean; fi
> - if test -f dtc/version_gen.h; then make $(DTC_MAKE_ARGS) clean; fi
> + if test -f pixman/config.log; then $(MAKE) -C pixman distclean; fi
> + if test -f dtc/version_gen.h; then $(MAKE) $(DTC_MAKE_ARGS) clean; fi
>
> KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \
> ar de en-us fi fr-be hr it lv nl pl ru th \
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread