* [rtc-linux] [PATCH] rtc: rtc-s3c: Remove one superfluous rtc_valid_tm() check
@ 2015-04-02 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-02 14:31 UTC (permalink / raw)
To: Alexandre Belloni, linux-samsung-soc, Alessandro Zummo, rtc-linux,
linux-kernel
Cc: Marek Szyprowski, Krzysztof Kozlowski
The s3c_rtc_gettime() returns already result of rtc_valid_tm() on
obtained time so get rid of another call to rtc_valid_tm().
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/rtc/rtc-s3c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 1d3a4c58fec4..a0f832362199 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -497,9 +497,7 @@ static int s3c_rtc_probe(struct platform_device *pdev)
device_init_wakeup(&pdev->dev, 1);
/* Check RTC Time */
- s3c_rtc_gettime(&pdev->dev, &rtc_tm);
-
- if (rtc_valid_tm(&rtc_tm)) {
+ if (s3c_rtc_gettime(&pdev->dev, &rtc_tm)) {
rtc_tm.tm_year = 100;
rtc_tm.tm_mon = 0;
rtc_tm.tm_mday = 1;
--
1.9.1
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] rtc: rtc-s3c: Remove one superfluous rtc_valid_tm() check
@ 2015-04-02 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-02 14:31 UTC (permalink / raw)
To: Alexandre Belloni, linux-samsung-soc, Alessandro Zummo, rtc-linux,
linux-kernel
Cc: Marek Szyprowski, Krzysztof Kozlowski
The s3c_rtc_gettime() returns already result of rtc_valid_tm() on
obtained time so get rid of another call to rtc_valid_tm().
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/rtc/rtc-s3c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 1d3a4c58fec4..a0f832362199 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -497,9 +497,7 @@ static int s3c_rtc_probe(struct platform_device *pdev)
device_init_wakeup(&pdev->dev, 1);
/* Check RTC Time */
- s3c_rtc_gettime(&pdev->dev, &rtc_tm);
-
- if (rtc_valid_tm(&rtc_tm)) {
+ if (s3c_rtc_gettime(&pdev->dev, &rtc_tm)) {
rtc_tm.tm_year = 100;
rtc_tm.tm_mon = 0;
rtc_tm.tm_mday = 1;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [rtc-linux] Re: [PATCH] rtc: rtc-s3c: Remove one superfluous rtc_valid_tm() check
2015-04-02 14:31 ` Krzysztof Kozlowski
@ 2015-04-02 23:44 ` Chanwoo Choi
-1 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2015-04-02 23:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alexandre Belloni, linux-samsung-soc, Alessandro Zummo, rtc-linux,
linux-kernel, Marek Szyprowski
On 04/02/2015 11:31 PM, Krzysztof Kozlowski wrote:
> The s3c_rtc_gettime() returns already result of rtc_valid_tm() on
> obtained time so get rid of another call to rtc_valid_tm().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index 1d3a4c58fec4..a0f832362199 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -497,9 +497,7 @@ static int s3c_rtc_probe(struct platform_device *pdev)
> device_init_wakeup(&pdev->dev, 1);
>
> /* Check RTC Time */
> - s3c_rtc_gettime(&pdev->dev, &rtc_tm);
> -
> - if (rtc_valid_tm(&rtc_tm)) {
> + if (s3c_rtc_gettime(&pdev->dev, &rtc_tm)) {
> rtc_tm.tm_year = 100;
> rtc_tm.tm_mon = 0;
> rtc_tm.tm_mday = 1;
>
s3c_rtc_gettime() return the value of rtc_valid_tm(). Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rtc: rtc-s3c: Remove one superfluous rtc_valid_tm() check
@ 2015-04-02 23:44 ` Chanwoo Choi
0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2015-04-02 23:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alexandre Belloni, linux-samsung-soc, Alessandro Zummo, rtc-linux,
linux-kernel, Marek Szyprowski
On 04/02/2015 11:31 PM, Krzysztof Kozlowski wrote:
> The s3c_rtc_gettime() returns already result of rtc_valid_tm() on
> obtained time so get rid of another call to rtc_valid_tm().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index 1d3a4c58fec4..a0f832362199 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -497,9 +497,7 @@ static int s3c_rtc_probe(struct platform_device *pdev)
> device_init_wakeup(&pdev->dev, 1);
>
> /* Check RTC Time */
> - s3c_rtc_gettime(&pdev->dev, &rtc_tm);
> -
> - if (rtc_valid_tm(&rtc_tm)) {
> + if (s3c_rtc_gettime(&pdev->dev, &rtc_tm)) {
> rtc_tm.tm_year = 100;
> rtc_tm.tm_mon = 0;
> rtc_tm.tm_mday = 1;
>
s3c_rtc_gettime() return the value of rtc_valid_tm(). Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-02 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-02 14:31 [rtc-linux] [PATCH] rtc: rtc-s3c: Remove one superfluous rtc_valid_tm() check Krzysztof Kozlowski
2015-04-02 14:31 ` Krzysztof Kozlowski
2015-04-02 23:44 ` [rtc-linux] " Chanwoo Choi
2015-04-02 23:44 ` Chanwoo Choi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.