All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charlie WONG Super <1213charlie@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: fbtft: Replace spaces to tab
Date: Fri, 03 Apr 2015 14:08:30 +0800	[thread overview]
Message-ID: <551E2E5E.8090001@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1504030746190.2011@localhost6.localdomain6>

On 2015年04月03日 13:46, Julia Lawall wrote:
>
> On Fri, 3 Apr 2015, Charlie WONG Super wrote:
>
>> From: Charlie Wong Super <1213charlie@gmail.com>
>>
>> Spaces at the start of the line, replace the leading space to tabs
>>
>> Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
>> ---
>>   drivers/staging/fbtft/fb_st7735r.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
>> index 9d87430..8728347 100644
>> --- a/drivers/staging/fbtft/fb_st7735r.c
>> +++ b/drivers/staging/fbtft/fb_st7735r.c
>> @@ -25,8 +25,8 @@
>>   #include "fbtft.h"
>>   
>>   #define DRVNAME "fb_st7735r"
>> -#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
>> -                      "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
>> +#define DEFAULT_GAMMA	"0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
> You don't need a tab after GAMMA.
>
> julia
can I use space to make the two line align?
>
>> +			"0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
>>   
>>   
>>   static int default_init_sequence[] = {
>> @@ -119,9 +119,9 @@ static int set_var(struct fbtft_par *par)
>>   	/* MADCTL - Memory data access control
>>   	     RGB/BGR:
>>   	     1. Mode selection pin SRGB
>> -	        RGB H/W pin for color filter setting: 0=RGB, 1=BGR
>> +		RGB H/W pin for color filter setting: 0=RGB, 1=BGR
>>   	     2. MADCTL RGB bit
>> -	        RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
>> +		RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
>>   	switch (par->info->var.rotate) {
>>   	case 0:
>>   		write_reg(par, 0x36, MX | MY | (par->bgr << 3));
>> -- 
>> 1.9.1
>>
>>



  reply	other threads:[~2015-04-03  6:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03  5:33 [PATCH] staging: fbtft: Replace spaces to tab Charlie WONG Super
2015-04-03  5:46 ` Julia Lawall
2015-04-03  6:08   ` Charlie WONG Super [this message]
2015-04-03  6:39   ` [PATCH v2] " Charlie WONG Super
2015-04-03  8:10 ` [Outreachy kernel] [PATCH] " Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2015-04-04 11:30 Charlie WONG Super

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551E2E5E.8090001@gmail.com \
    --to=1213charlie@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.