* [PATCH] staging: fbtft: Replace spaces to tab
@ 2015-04-03 5:33 Charlie WONG Super
2015-04-03 5:46 ` Julia Lawall
2015-04-03 8:10 ` [Outreachy kernel] [PATCH] " Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Charlie WONG Super @ 2015-04-03 5:33 UTC (permalink / raw)
To: julia.lawall, gregkh; +Cc: outreachy-kernel, Charlie Wong Super
From: Charlie Wong Super <1213charlie@gmail.com>
Spaces at the start of the line, replace the leading space to tabs
Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
---
drivers/staging/fbtft/fb_st7735r.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
index 9d87430..8728347 100644
--- a/drivers/staging/fbtft/fb_st7735r.c
+++ b/drivers/staging/fbtft/fb_st7735r.c
@@ -25,8 +25,8 @@
#include "fbtft.h"
#define DRVNAME "fb_st7735r"
-#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
- "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
+#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
+ "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
static int default_init_sequence[] = {
@@ -119,9 +119,9 @@ static int set_var(struct fbtft_par *par)
/* MADCTL - Memory data access control
RGB/BGR:
1. Mode selection pin SRGB
- RGB H/W pin for color filter setting: 0=RGB, 1=BGR
+ RGB H/W pin for color filter setting: 0=RGB, 1=BGR
2. MADCTL RGB bit
- RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
+ RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
switch (par->info->var.rotate) {
case 0:
write_reg(par, 0x36, MX | MY | (par->bgr << 3));
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: Replace spaces to tab
2015-04-03 5:33 [PATCH] staging: fbtft: Replace spaces to tab Charlie WONG Super
@ 2015-04-03 5:46 ` Julia Lawall
2015-04-03 6:08 ` Charlie WONG Super
2015-04-03 6:39 ` [PATCH v2] " Charlie WONG Super
2015-04-03 8:10 ` [Outreachy kernel] [PATCH] " Greg KH
1 sibling, 2 replies; 6+ messages in thread
From: Julia Lawall @ 2015-04-03 5:46 UTC (permalink / raw)
To: Charlie WONG Super; +Cc: gregkh, outreachy-kernel
On Fri, 3 Apr 2015, Charlie WONG Super wrote:
> From: Charlie Wong Super <1213charlie@gmail.com>
>
> Spaces at the start of the line, replace the leading space to tabs
>
> Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
> ---
> drivers/staging/fbtft/fb_st7735r.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
> index 9d87430..8728347 100644
> --- a/drivers/staging/fbtft/fb_st7735r.c
> +++ b/drivers/staging/fbtft/fb_st7735r.c
> @@ -25,8 +25,8 @@
> #include "fbtft.h"
>
> #define DRVNAME "fb_st7735r"
> -#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
> - "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
> +#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
You don't need a tab after GAMMA.
julia
> + "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
>
>
> static int default_init_sequence[] = {
> @@ -119,9 +119,9 @@ static int set_var(struct fbtft_par *par)
> /* MADCTL - Memory data access control
> RGB/BGR:
> 1. Mode selection pin SRGB
> - RGB H/W pin for color filter setting: 0=RGB, 1=BGR
> + RGB H/W pin for color filter setting: 0=RGB, 1=BGR
> 2. MADCTL RGB bit
> - RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
> + RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
> switch (par->info->var.rotate) {
> case 0:
> write_reg(par, 0x36, MX | MY | (par->bgr << 3));
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: Replace spaces to tab
2015-04-03 5:46 ` Julia Lawall
@ 2015-04-03 6:08 ` Charlie WONG Super
2015-04-03 6:39 ` [PATCH v2] " Charlie WONG Super
1 sibling, 0 replies; 6+ messages in thread
From: Charlie WONG Super @ 2015-04-03 6:08 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
On 2015年04月03日 13:46, Julia Lawall wrote:
>
> On Fri, 3 Apr 2015, Charlie WONG Super wrote:
>
>> From: Charlie Wong Super <1213charlie@gmail.com>
>>
>> Spaces at the start of the line, replace the leading space to tabs
>>
>> Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
>> ---
>> drivers/staging/fbtft/fb_st7735r.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
>> index 9d87430..8728347 100644
>> --- a/drivers/staging/fbtft/fb_st7735r.c
>> +++ b/drivers/staging/fbtft/fb_st7735r.c
>> @@ -25,8 +25,8 @@
>> #include "fbtft.h"
>>
>> #define DRVNAME "fb_st7735r"
>> -#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
>> - "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
>> +#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
> You don't need a tab after GAMMA.
>
> julia
can I use space to make the two line align?
>
>> + "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
>>
>>
>> static int default_init_sequence[] = {
>> @@ -119,9 +119,9 @@ static int set_var(struct fbtft_par *par)
>> /* MADCTL - Memory data access control
>> RGB/BGR:
>> 1. Mode selection pin SRGB
>> - RGB H/W pin for color filter setting: 0=RGB, 1=BGR
>> + RGB H/W pin for color filter setting: 0=RGB, 1=BGR
>> 2. MADCTL RGB bit
>> - RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
>> + RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
>> switch (par->info->var.rotate) {
>> case 0:
>> write_reg(par, 0x36, MX | MY | (par->bgr << 3));
>> --
>> 1.9.1
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] staging: fbtft: Replace spaces to tab
2015-04-03 5:46 ` Julia Lawall
2015-04-03 6:08 ` Charlie WONG Super
@ 2015-04-03 6:39 ` Charlie WONG Super
1 sibling, 0 replies; 6+ messages in thread
From: Charlie WONG Super @ 2015-04-03 6:39 UTC (permalink / raw)
To: julia.lawall; +Cc: outreachy-kernel, Charlie Wong Super
From: Charlie Wong Super <1213charlie@gmail.com>
Spaces at the start of the line, replace the leading space to tabs
Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
---
Changes in v2:
- After GAMMA, use space to keep aligning with the next line
replace former tab(former version use a tap)
drivers/staging/fbtft/fb_st7735r.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
index 9d87430..f652243 100644
--- a/drivers/staging/fbtft/fb_st7735r.c
+++ b/drivers/staging/fbtft/fb_st7735r.c
@@ -25,8 +25,8 @@
#include "fbtft.h"
#define DRVNAME "fb_st7735r"
-#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
- "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
+#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
+ "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
static int default_init_sequence[] = {
@@ -119,9 +119,9 @@ static int set_var(struct fbtft_par *par)
/* MADCTL - Memory data access control
RGB/BGR:
1. Mode selection pin SRGB
- RGB H/W pin for color filter setting: 0=RGB, 1=BGR
+ RGB H/W pin for color filter setting: 0=RGB, 1=BGR
2. MADCTL RGB bit
- RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
+ RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
switch (par->info->var.rotate) {
case 0:
write_reg(par, 0x36, MX | MY | (par->bgr << 3));
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace spaces to tab
2015-04-03 5:33 [PATCH] staging: fbtft: Replace spaces to tab Charlie WONG Super
2015-04-03 5:46 ` Julia Lawall
@ 2015-04-03 8:10 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2015-04-03 8:10 UTC (permalink / raw)
To: Charlie WONG Super; +Cc: julia.lawall, outreachy-kernel
On Fri, Apr 03, 2015 at 01:33:19PM +0800, Charlie WONG Super wrote:
> From: Charlie Wong Super <1213charlie@gmail.com>
>
> Spaces at the start of the line, replace the leading space to tabs
>
> Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
> ---
> drivers/staging/fbtft/fb_st7735r.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
The outreachy application period is over, please use the "normal"
mailing lists for sending in staging patches. Julia gave a list of how
to use scripts/get_maintainer.pl for how to determine who to send the
patches to.
I'm not going to be taking any new patches from this mailing list at
this point in time, sorry.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: fbtft: Replace spaces to tab
@ 2015-04-04 11:30 Charlie WONG Super
0 siblings, 0 replies; 6+ messages in thread
From: Charlie WONG Super @ 2015-04-04 11:30 UTC (permalink / raw)
To: gregkh, thomas.petazzoni, notro, hamohammed.sa
Cc: linux-kernel, Charlie Wong Super
From: Charlie Wong Super <1213charlie@gmail.com>
Spaces at the start of the line, replace the leading space to tabs
Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
---
Note:
- Get your email address from the scripts/get_maintainer.pl
- so I send this email to you
Changes:
- After GAMMA, use space to keep aligning with the next line
- The next line after GAMMA, leading with 3-taps
- I creat a branch,and git am this patch, though it looks not good in
the patch, but it works fine in realy life.
drivers/staging/fbtft/fb_st7735r.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
index 9d87430..f652243 100644
--- a/drivers/staging/fbtft/fb_st7735r.c
+++ b/drivers/staging/fbtft/fb_st7735r.c
@@ -25,8 +25,8 @@
#include "fbtft.h"
#define DRVNAME "fb_st7735r"
-#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
- "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
+#define DEFAULT_GAMMA "0F 1A 0F 18 2F 28 20 22 1F 1B 23 37 00 07 02 10\n" \
+ "0F 1B 0F 17 33 2C 29 2E 30 30 39 3F 00 07 03 10"
static int default_init_sequence[] = {
@@ -119,9 +119,9 @@ static int set_var(struct fbtft_par *par)
/* MADCTL - Memory data access control
RGB/BGR:
1. Mode selection pin SRGB
- RGB H/W pin for color filter setting: 0=RGB, 1=BGR
+ RGB H/W pin for color filter setting: 0=RGB, 1=BGR
2. MADCTL RGB bit
- RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
+ RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
switch (par->info->var.rotate) {
case 0:
write_reg(par, 0x36, MX | MY | (par->bgr << 3));
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-04 11:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-03 5:33 [PATCH] staging: fbtft: Replace spaces to tab Charlie WONG Super
2015-04-03 5:46 ` Julia Lawall
2015-04-03 6:08 ` Charlie WONG Super
2015-04-03 6:39 ` [PATCH v2] " Charlie WONG Super
2015-04-03 8:10 ` [Outreachy kernel] [PATCH] " Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-04-04 11:30 Charlie WONG Super
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.