From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm, memcg: sync allocation and memcg charge gfp flags for thp fix fix
Date: Fri, 03 Apr 2015 10:38:05 +0200 [thread overview]
Message-ID: <551E516D.4050803@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1504021836180.20229@chino.kir.corp.google.com>
On 04/03/2015 03:41 AM, David Rientjes wrote:
> "mm, memcg: sync allocation and memcg charge gfp flags for THP" in -mm
> introduces a formal to pass the gfp mask for khugepaged's hugepage
> allocation. This is just too ugly to live.
>
> alloc_hugepage_gfpmask() cannot differ between NUMA and UMA configs by
> anything in GFP_RECLAIM_MASK, which is the only thing that matters for
> memcg reclaim, so just determine the gfp flags once in
> collapse_huge_page() and avoid the complexity.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm, memcg: sync allocation and memcg charge gfp flags for thp fix fix
Date: Fri, 03 Apr 2015 10:38:05 +0200 [thread overview]
Message-ID: <551E516D.4050803@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1504021836180.20229@chino.kir.corp.google.com>
On 04/03/2015 03:41 AM, David Rientjes wrote:
> "mm, memcg: sync allocation and memcg charge gfp flags for THP" in -mm
> introduces a formal to pass the gfp mask for khugepaged's hugepage
> allocation. This is just too ugly to live.
>
> alloc_hugepage_gfpmask() cannot differ between NUMA and UMA configs by
> anything in GFP_RECLAIM_MASK, which is the only thing that matters for
> memcg reclaim, so just determine the gfp flags once in
> collapse_huge_page() and avoid the complexity.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2015-04-03 8:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 14:08 [PATCH] mm, memcg: sync allocation and memcg charge gfp flags for THP Michal Hocko
2015-03-16 14:08 ` Michal Hocko
2015-03-18 14:34 ` Vlastimil Babka
2015-03-18 14:34 ` Vlastimil Babka
2015-03-18 15:02 ` Michal Hocko
2015-03-18 15:02 ` Michal Hocko
2015-03-18 15:40 ` Vlastimil Babka
2015-03-18 15:40 ` Vlastimil Babka
2015-03-18 15:59 ` Michal Hocko
2015-03-18 15:59 ` Michal Hocko
2015-03-18 16:09 ` Vlastimil Babka
2015-03-18 16:09 ` Vlastimil Babka
2015-03-18 16:14 ` [PATCH -v2] " Michal Hocko
2015-03-18 16:14 ` Michal Hocko
2015-04-03 1:41 ` [patch] mm, memcg: sync allocation and memcg charge gfp flags for thp fix fix David Rientjes
2015-04-03 1:41 ` David Rientjes
2015-04-03 8:38 ` Vlastimil Babka [this message]
2015-04-03 8:38 ` Vlastimil Babka
2015-04-03 10:50 ` Michal Hocko
2015-04-03 10:50 ` Michal Hocko
2015-04-04 1:34 ` [PATCH -v2] mm, memcg: sync allocation and memcg charge gfp flags for THP David Rientjes
2015-04-04 1:34 ` David Rientjes
2015-04-07 12:19 ` Michal Hocko
2015-04-07 12:19 ` Michal Hocko
[not found] <058201d06de5$9e15edc0$da41c940$@alibaba-inc.com>
2015-04-03 8:14 ` [patch] mm, memcg: sync allocation and memcg charge gfp flags for thp fix fix Hillf Danton
2015-04-03 8:14 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551E516D.4050803@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.