From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 14/16] soc: ti: knav_qmss_queue: fix error return code
Date: Mon, 06 Apr 2015 02:03:15 +0000 [thread overview]
Message-ID: <5521E963.5080903@oracle.com> (raw)
In-Reply-To: <1428235596-4757-15-git-send-email-Julia.Lawall@lip6.fr>
On 4/5/15 5:06 AM, Julia Lawall wrote:
> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@oracle.com (santosh.shilimkar at oracle.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/16] soc: ti: knav_qmss_queue: fix error return code
Date: Sun, 05 Apr 2015 19:03:15 -0700 [thread overview]
Message-ID: <5521E963.5080903@oracle.com> (raw)
In-Reply-To: <1428235596-4757-15-git-send-email-Julia.Lawall@lip6.fr>
On 4/5/15 5:06 AM, Julia Lawall wrote:
> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 14/16] soc: ti: knav_qmss_queue: fix error return code
Date: Sun, 05 Apr 2015 19:03:15 -0700 [thread overview]
Message-ID: <5521E963.5080903@oracle.com> (raw)
In-Reply-To: <1428235596-4757-15-git-send-email-Julia.Lawall@lip6.fr>
On 4/5/15 5:06 AM, Julia Lawall wrote:
> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
next prev parent reply other threads:[~2015-04-06 2:03 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 12:06 [PATCH 0/16] fix error return code Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 1/16] wan: lmc: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-07 19:26 ` David Miller
2015-04-07 19:26 ` David Miller
2015-04-05 12:06 ` [PATCH 2/16] [media] si4713: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 4/16] [media] as102: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 3/16] [media] radio: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 5/16] ufs: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 6/16] HSI: cmt_speech: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:47 ` Sebastian Reichel
2015-04-05 12:47 ` Sebastian Reichel
2015-04-05 12:06 ` [PATCH 7/16] parport_sunbpp: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 8/16] cosa: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-07 19:26 ` David Miller
2015-04-07 19:26 ` David Miller
2015-04-05 12:06 ` [PATCH 9/16] HID: logitech-hidpp: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 14:38 ` Benjamin Tissoires
2015-04-05 14:38 ` Benjamin Tissoires
2015-04-05 20:57 ` Jiri Kosina
2015-04-05 20:57 ` Jiri Kosina
2015-04-05 12:06 ` [PATCH 10/16] zram: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 11/16] drm/msm/dp: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` [PATCH 12/16] ib_srpt: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
[not found] ` <1428235596-4757-13-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2015-04-05 16:27 ` Bart Van Assche
2015-04-05 16:27 ` Bart Van Assche
2015-04-05 16:27 ` Bart Van Assche
2015-04-05 12:06 ` [PATCH 13/16] ALSA: au1x00: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 16:06 ` [alsa-devel] " Takashi Iwai
2015-04-05 16:06 ` Takashi Iwai
2015-04-05 12:06 ` [PATCH 14/16] soc: ti: knav_qmss_queue: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-06 2:03 ` santosh.shilimkar [this message]
2015-04-06 2:03 ` santosh.shilimkar
2015-04-06 2:03 ` santosh.shilimkar at oracle.com
2015-04-05 12:06 ` [PATCH 15/16] staging: lustre: lnet: lnet: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-06 6:41 ` [HPDD-discuss] " Zhen, Liang
2015-04-06 6:41 ` Zhen, Liang
2015-04-05 12:06 ` [PATCH 16/16] NFC: pn533: " Julia Lawall
2015-04-05 12:06 ` Julia Lawall
2015-04-05 23:23 ` Samuel Ortiz
2015-04-05 23:23 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5521E963.5080903@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.