From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH 0/4] Do not DMA on the stack
Date: Sun, 04 Oct 2015 22:39:27 +0200 [thread overview]
Message-ID: <5522999.85D2llbvgZ@wuerfel> (raw)
In-Reply-To: <cover.1443989364.git.ksenija.stanojevic@gmail.com>
On Sunday 04 October 2015 22:13:02 Ksenija Stanojevic wrote:
> Fix error "doing DMA on the stack" by using kzalloc for buffer
> allocation in rtl8192u/r8192U_core.c in the following functions:
> write_nic_byte_E()
> write_nic_byte()
> write_nic_word()
> write_nic_dword()
> Issue found by smatch.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>
> Ksenija Stanojevic (4):
> Staging: rtl8192u: Do not DMA on the stack in write_nic_byte_E()
> Staging: rtl8192u: Do not DMA on the stack in write_nic_byte()
> Staging: rtl8192u: Do not DMA on the stack in write_nic_word()
> Staging: rtl8192u: Do not DMA on the stack in write_nic_dword()
>
The changes all look wrong to me, can you guess what the problem is
when you read them again?
Also, these are four instances of the same code, in the same file,
so it would be reasonable to do a single patch, and then you can
do the other five instances in the same file as well.
Arnd
next prev parent reply other threads:[~2015-10-04 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 20:13 [PATCH 0/4] Do not DMA on the stack Ksenija Stanojevic
2015-10-04 20:14 ` [PATCH 1/4] Staging: rtl8192u: Do not DMA on the stack in write_nic_byte_E() Ksenija Stanojevic
2015-10-05 3:17 ` [Outreachy kernel] " Greg KH
2015-10-05 3:27 ` Ksenija Stanojević
2015-10-04 20:14 ` [PATCH 2/4] Staging: rtl8192u: Do not DMA on the stack in write_nic_byte() Ksenija Stanojevic
2015-10-04 20:14 ` [PATCH 3/4] Staging: rtl8192u: Do not DMA on the stack in write_nic_word() Ksenija Stanojevic
2015-10-04 20:15 ` [PATCH 4/4] Staging: rtl8192u: Do not DMA on the stack in write_nic_dword() Ksenija Stanojevic
2015-10-05 3:27 ` Ksenija Stanojević
2015-10-04 20:39 ` Arnd Bergmann [this message]
2015-10-05 5:28 ` [Outreachy kernel] [PATCH 0/4] Do not DMA on the stack Ksenija Stanojević
2015-10-05 6:40 ` Ksenija Stanojević
2015-10-05 6:44 ` Ksenija Stanojević
2015-10-05 6:50 ` Ksenija Stanojević
2015-10-05 8:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5522999.85D2llbvgZ@wuerfel \
--to=arnd@arndb.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.