Re: [Outreachy kernel] [PATCH 0/4] Do not DMA on the stack

[Arnd Bergmann <arnd@arndb.de>]

On Monday 05 October 2015 08:50:09 Ksenija Stanojević wrote:
> On Mon, Oct 5, 2015 at 8:44 AM, Ksenija Stanojević
> <ksenija.stanojevic@gmail.com> wrote:
> > On Mon, Oct 5, 2015 at 8:40 AM, Ksenija Stanojević
> > <ksenija.stanojevic@gmail.com> wrote:
> >> On Mon, Oct 5, 2015 at 7:28 AM, Ksenija Stanojević
> >> <ksenija.stanojevic@gmail.com> wrote:
> >>> On Sun, Oct 4, 2015 at 10:39 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> >>>> On Sunday 04 October 2015 22:13:02 Ksenija Stanojevic wrote:
> >>>>> Fix error "doing DMA on the stack" by using kzalloc for buffer
> >>>>> allocation in rtl8192u/r8192U_core.c in the following functions:
> >>>>>         write_nic_byte_E()
> >>>>>         write_nic_byte()
> >>>>>         write_nic_word()
> >>>>>         write_nic_dword()
> >>>>> Issue found by smatch.
> >>>>>
> >>>>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >>>>>
> >>>>> Ksenija Stanojevic (4):
> >>>>>   Staging: rtl8192u: Do not DMA on the stack in write_nic_byte_E()
> >>>>>   Staging: rtl8192u: Do not DMA on the stack in write_nic_byte()
> >>>>>   Staging: rtl8192u: Do not DMA on the stack in write_nic_word()
> >>>>>   Staging: rtl8192u: Do not DMA on the stack in write_nic_dword()
> >>>>>
> >>>>
> >>>> The changes all look wrong to me, can you guess what the problem is
> >>>> when you read them again?
> >>>
> > Please ignore this.
> >> And also assign pdata to point to data
> >>  pdata = &data;
> 
> I meant *pdata = data.

Right. Once you change that, it should be fine.

	Arnd