[prelink-cross][PATCH 1/1] debug message for dependencies not found

[prelink-cross][PATCH 1/1] debug message for dependencies not found

[Maninder Singh]

Hi,
Same mail sent earlier Changing subject line, By mistake shared subject line of other patch.

prelink gives below error message for failure dependency:
./prelink: /test_binary: Could not find one of the dependencies

This provides name of dependent library which is missing like below:
./prelink: /test_binary: Could not find one of the dependencies:
./prelink-rtld: error while loading shared libraries: libB.so: cannot open shared object file: No such file or directory
where libB.so is missing dependecy

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Signed-off-by: Vaneet Narang <v.narang@samsung.com>
Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
Reviewed-by: Geon-ho Kim <gh007.kim@samsung.com>
---
 src/gather.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gather.c b/src/gather.c
index 5ccd243..4a3f428 100644
--- a/src/gather.c
+++ b/src/gather.c
@@ -240,8 +240,8 @@ gather_deps (DSO *dso, struct prelink_entry *ent)
          if (q != NULL)
            {
              error (0, 0,
-                "%s: Could not find one of the dependencies",
-                ent->filename);
+                "%s: Could not find one of the dependencies:\n%s",
+                ent->filename, line);
              goto error_out;
            }
        }
--


Thanks 
Maninder Singh

Re: [prelink-cross][PATCH 1/1] debug message for dependencies not found

[Mark Hatle]

This and the other patch have been merged onto the cross_prelink_staging branch.

Please test that I merged it properly.  (Everything passed my basic testing, but
I haven't run it against any ARM/HF libraries or similar.)

--Mark

On 4/6/15 4:07 AM, Maninder Singh wrote:
> Hi,
> Same mail sent earlier Changing subject line, By mistake shared subject line of other patch.
> 
> prelink gives below error message for failure dependency:
> ./prelink: /test_binary: Could not find one of the dependencies
> 
> This provides name of dependent library which is missing like below:
> ./prelink: /test_binary: Could not find one of the dependencies:
> ./prelink-rtld: error while loading shared libraries: libB.so: cannot open shared object file: No such file or directory
> where libB.so is missing dependecy
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
> Reviewed-by: Geon-ho Kim <gh007.kim@samsung.com>
> ---
>  src/gather.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gather.c b/src/gather.c
> index 5ccd243..4a3f428 100644
> --- a/src/gather.c
> +++ b/src/gather.c
> @@ -240,8 +240,8 @@ gather_deps (DSO *dso, struct prelink_entry *ent)
>           if (q != NULL)
>             {
>               error (0, 0,
> -                "%s: Could not find one of the dependencies",
> -                ent->filename);
> +                "%s: Could not find one of the dependencies:\n%s",
> +                ent->filename, line);
>               goto error_out;
>             }
>         }
> --
> 
> 
> Thanks 
> Maninder Singh
> 

Re: [prelink-cross][PATCH 1/1] debug message for dependencies not found

[Maninder Singh]

Hi Mark,

We have checked the commit on cross_prelik_staging, it is correct But i did one typo error Please correct following:-
Just change Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
to
Reviewed-by: Ajeet Yadav <ajeet.y@samsung.com> for voth patches.
Typo arror for ajeet.v ---> ajeet.y
Thanks
Maninder Singh
>This and the other patch have been merged onto the cross_prelink_staging branch.

>Please test that I merged it properly.  (Everything passed my basic testing, but
>I haven't run it against any ARM/HF libraries or similar.)

>--Mark

On 4/6/15 4:07 AM, Maninder Singh wrote:
> Hi,
> Same mail sent earlier Changing subject line, By mistake shared subject line of other patch.
> 
> prelink gives below error message for failure dependency:
> ./prelink: /test_binary: Could not find one of the dependencies
> 
> This provides name of dependent library which is missing like below:
> ./prelink: /test_binary: Could not find one of the dependencies:
> ./prelink-rtld: error while loading shared libraries: libB.so: cannot open shared object file: No such file or directory
> where libB.so is missing dependecy
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
> Reviewed-by: Geon-ho Kim <gh007.kim@samsung.com>
> ---
>  src/gather.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gather.c b/src/gather.c
> index 5ccd243..4a3f428 100644
> --- a/src/gather.c
> +++ b/src/gather.c
> @@ -240,8 +240,8 @@ gather_deps (DSO *dso, struct prelink_entry *ent)
>           if (q != NULL)
>             {
>               error (0, 0,
> -                "%s: Could not find one of the dependencies",
> -                ent->filename);
> +                "%s: Could not find one of the dependencies:\n%s",
> +                ent->filename, line);
>               goto error_out;
>             }
>         }
> --
> 
> 
> Thanks 
> Maninder Singh
> 

Re: [prelink-cross][PATCH 1/1] debug message for dependencies not found

[Mark Hatle]

On 4/7/15 5:15 AM, Maninder Singh wrote:
> Hi Mark,
> 
> We have checked the commit on cross_prelik_staging, it is correct But i did one typo error Please correct following:-
> Just change Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
> to
> Reviewed-by: Ajeet Yadav <ajeet.y@samsung.com> for voth patches.
> Typo arror for ajeet.v ---> ajeet.y

Fixed in the commit message.  I'm going to let this sit in the staging for a bit
longer, then merge it to the cross_prelink branch and eventually Yocto Project/OE.

--Mark

> Thanks
> Maninder Singh
>> This and the other patch have been merged onto the cross_prelink_staging branch.
> 
>> Please test that I merged it properly.  (Everything passed my basic testing, but
>> I haven't run it against any ARM/HF libraries or similar.)
> 
>> --Mark
> 
> On 4/6/15 4:07 AM, Maninder Singh wrote:
>> Hi,
>> Same mail sent earlier Changing subject line, By mistake shared subject line of other patch.
>>
>> prelink gives below error message for failure dependency:
>> ./prelink: /test_binary: Could not find one of the dependencies
>>
>> This provides name of dependent library which is missing like below:
>> ./prelink: /test_binary: Could not find one of the dependencies:
>> ./prelink-rtld: error while loading shared libraries: libB.so: cannot open shared object file: No such file or directory
>> where libB.so is missing dependecy
>>
>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
>> Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
>> Reviewed-by: Geon-ho Kim <gh007.kim@samsung.com>
>> ---
>>  src/gather.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/gather.c b/src/gather.c
>> index 5ccd243..4a3f428 100644
>> --- a/src/gather.c
>> +++ b/src/gather.c
>> @@ -240,8 +240,8 @@ gather_deps (DSO *dso, struct prelink_entry *ent)
>>           if (q != NULL)
>>             {
>>               error (0, 0,
>> -                "%s: Could not find one of the dependencies",
>> -                ent->filename);
>> +                "%s: Could not find one of the dependencies:\n%s",
>> +                ent->filename, line);
>>               goto error_out;
>>             }
>>         }
>> --
>>
>>
>> Thanks 
>> Maninder Singh
>>