From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off
Date: Tue, 07 Apr 2015 11:48:47 +0200 [thread overview]
Message-ID: <5523A7FF.2030700@collabora.co.uk> (raw)
In-Reply-To: <1428053635-10855-1-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 04/03/2015 11:33 AM, Krzysztof Kozlowski wrote:
> Using a fixed (by DTS) parent for clocks when turning on the power domain
> may introduce issues in other drivers. For example when such driver
> changes the parent during runtime and expects that he is the only place
> of such change.
>
> Do not rely on DTS providing the fixed parent for such clocks. Instead
> before switching domain off, grab a current parent of a clock with
> clk_get_parent().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Changes since v1:
> 1. Drop "pclk" bindings entirely as suggested by Andrzej Hajda.
> This was significant change so I did not add Javier's
> reviewed/tested tags.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
on an Exynos5420 Peach Pit Chromebook:
Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off
Date: Tue, 07 Apr 2015 11:48:47 +0200 [thread overview]
Message-ID: <5523A7FF.2030700@collabora.co.uk> (raw)
In-Reply-To: <1428053635-10855-1-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 04/03/2015 11:33 AM, Krzysztof Kozlowski wrote:
> Using a fixed (by DTS) parent for clocks when turning on the power domain
> may introduce issues in other drivers. For example when such driver
> changes the parent during runtime and expects that he is the only place
> of such change.
>
> Do not rely on DTS providing the fixed parent for such clocks. Instead
> before switching domain off, grab a current parent of a clock with
> clk_get_parent().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Changes since v1:
> 1. Drop "pclk" bindings entirely as suggested by Andrzej Hajda.
> This was significant change so I did not add Javier's
> reviewed/tested tags.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
on an Exynos5420 Peach Pit Chromebook:
Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
next prev parent reply other threads:[~2015-04-07 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 9:33 [PATCH v2 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off Krzysztof Kozlowski
2015-04-03 9:33 ` Krzysztof Kozlowski
2015-04-03 9:33 ` [PATCH v2 2/2] ARM: dts: Use last parent for clocks during " Krzysztof Kozlowski
2015-04-03 9:33 ` Krzysztof Kozlowski
2015-04-07 9:48 ` Javier Martinez Canillas [this message]
2015-04-07 9:48 ` [PATCH v2 1/2] ARM: EXYNOS: Get current parent clock for " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5523A7FF.2030700@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.