From: Julien Grall <julien.grall@citrix.com>
To: Chen Baozi <cbz@baozis.org>, xen-devel@lists.xen.org
Cc: Chen Baozi <baozich@gmail.com>,
julien.grall@linaro.org, ian.campbell@citrix.com
Subject: Re: [PATCH] xen/arm64: Use virtual address when setting up early_printk fixmap
Date: Tue, 7 Apr 2015 12:07:28 +0100 [thread overview]
Message-ID: <5523BA70.1040701@citrix.com> (raw)
In-Reply-To: <1428392004-11482-1-git-send-email-cbz@baozis.org>
Hi Chen,
On 07/04/2015 08:33, Chen Baozi wrote:
> From: Chen Baozi <baozich@gmail.com>
>
> We have already had the boot pagetable when reaching the point
> of early_printk fixmap setup. Thus there is no longer necessary
> to caculate physical address of xen_fixmap.
s/caculate/calculate/
OOI, is it a bug or a clean up?
>
> Signed-off-by: Chen Baozi <baozich@gmail.com>
> ---
> xen/arch/arm/arm64/head.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 75b7ee1..a2ac2d4 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -520,7 +520,6 @@ paging:
>
> /* Add UART to the fixmap table */
> ldr x1, =xen_fixmap
> - add x1, x1, x20 /* x1 := paddr (xen_fixmap) */
You need to add a comment on "ldr x1..." in order to explain what x1
contains. i.e /* x1 := vaddr (xen_fixmap) */
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-04-07 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 7:33 [PATCH] xen/arm64: Use virtual address when setting up early_printk fixmap Chen Baozi
2015-04-07 11:07 ` Julien Grall [this message]
2015-04-07 11:18 ` Chen Baozi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5523BA70.1040701@citrix.com \
--to=julien.grall@citrix.com \
--cc=baozich@gmail.com \
--cc=cbz@baozis.org \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.