Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On 04/07/2015 06:46 AM, Alberto Garcia wrote:
> On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote:
> 
>> So instead, this patch creates a new QObject subtype: QNull.
> 
> The code looks good, but Markus's approach of using a single instance
> seems probably a bit better for this case.

It's what we get for both independently tackling the same problem.  I
still plan to review Markus' series, and might post an updated version
that takes the best of our two approaches.

> 
>> --- /dev/null
>> +++ b/include/qapi/qmp/qnull.h
>> @@ -0,0 +1,23 @@
>> +/*
>> + * QBool Module
> 
> You probably meant QNull here.

My blatant use of copy-and-paste shines through :)  I'll certainly fix
that, if my approach is still worth using.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]