Changes to contribute-to-toaster documented work-flow

Changes to contribute-to-toaster documented work-flow

[Lerner, Dave]

Hi Michael,

I note that your last modifications to "Contribut to Toaster" https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster you have setup a number of significant changes to the workflow and reduction of details for developers that are new or only occasionally contribute including:

Workflow change:  only email submissions of patches are documented
Removed:  Details on using the remote git repository( which are handy for those of us using wrapped and differing git procedures for our day jobs)
Workflow change:  use of virtualenv only
Removed:  Section on Set up the project and local interface
Removed:  using pip to install python modules
Removed: validation of html, unix formatting, no eol whitespace
Removed:  implied references to the port number used by toaster

Can we put back some of the information that was removed at least wrt to using the remote git repos or were there complaints from someone?

Thanks,
Dave Lerner

Re: Changes to contribute-to-toaster documented work-flow

[Reyna, David]

Hi Michael,

I must concur on my distress on the changes. 

Why have you removed everything related to "poky-contrib"? I use the sections about setting up branches, submitting branches, and deleting branches all of the time. This is how we share and review our proposed changes.

I do understand that "pip install -r ./bitbake/toaster-requirements.txt" wraps the previous steps of installing the python-related packages like Django and South; the old part was out of date.

- David

> -----Original Message-----
> From: toaster-bounces@yoctoproject.org [mailto:toaster-
> bounces@yoctoproject.org] On Behalf Of Lerner, Dave
> Sent: Monday, April 06, 2015 1:22 PM
> To: WOOD, MICHAEL
> Cc: toaster@yoctoproject.org
> Subject: [Toaster] Changes to contribute-to-toaster documented work-flow
> 
> Hi Michael,
> 
> I note that your last modifications to "Contribut to Toaster"
> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster you have setup a
> number of significant changes to the workflow and reduction of details for
> developers that are new or only occasionally contribute including:
> 
> Workflow change:  only email submissions of patches are documented
> Removed:  Details on using the remote git repository( which are handy for
> those of us using wrapped and differing git procedures for our day jobs)
> Workflow change:  use of virtualenv only
> Removed:  Section on Set up the project and local interface
> Removed:  using pip to install python modules
> Removed: validation of html, unix formatting, no eol whitespace
> Removed:  implied references to the port number used by toaster
> 
> Can we put back some of the information that was removed at least wrt to
> using the remote git repos or were there complaints from someone?
> 
> Thanks,
> Dave Lerner
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster

Re: Changes to contribute-to-toaster documented work-flow

[Michael Wood]

Hey,

Hmm, looks like I lost some of my changes. I've added back some of the 
lost info and comments below. Hope that helps.

> Workflow change:  only email submissions of patches are documented
> Removed:  Details on using the remote git repository( which are handy for
> those of us using wrapped and differing git procedures for our day jobs)

I've added back the branch submission section, I removed it and put a link to the existing instructions https://wiki.yoctoproject.org/wiki/Poky_Contributions#Poky_Contrib_Branch

> Workflow change:  use of virtualenv only
virtualenv allows us to ensure that we're all using the same version of the python modules we depend on, this should mean that bugs aren't introduced/caused by distro python modules which version miss matches.

> Removed:  Section on Set up the project and local interface

We now have the Toaster manual so for general instructions this should be the best place, it was slightly out of date so better to just have a link to the Toaster manual

> Removed:  using pip to install python modules
See virtualenv bit
> Removed: validation of html, unix formatting, no eol whitespace
Moved that info to the style section
> Removed:  implied references to the port number used by toaster
When you start up django outputs the URL of the instance, if the port is in use it will state this on start up.


Michael


On 06/04/15 21:49, Reyna, David L (Wind River) wrote:
> Hi Michael,
>
> I must concur on my distress on the changes.
>
> Why have you removed everything related to "poky-contrib"? I use the sections about setting up branches, submitting branches, and deleting branches all of the time. This is how we share and review our proposed changes.
>
> I do understand that "pip install -r ./bitbake/toaster-requirements.txt" wraps the previous steps of installing the python-related packages like Django and South; the old part was out of date.
>
> - David
>
>> -----Original Message-----
>> From: toaster-bounces@yoctoproject.org [mailto:toaster-
>> bounces@yoctoproject.org] On Behalf Of Lerner, Dave
>> Sent: Monday, April 06, 2015 1:22 PM
>> To: WOOD, MICHAEL
>> Cc: toaster@yoctoproject.org
>> Subject: [Toaster] Changes to contribute-to-toaster documented work-flow
>>
>> Hi Michael,
>>
>> I note that your last modifications to "Contribut to Toaster"
>> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster you have setup a
>> number of significant changes to the workflow and reduction of details for
>> developers that are new or only occasionally contribute including:
>>
>> Workflow change:  only email submissions of patches are documented
>> Removed:  Details on using the remote git repository( which are handy for
>> those of us using wrapped and differing git procedures for our day jobs)
>> Workflow change:  use of virtualenv only
>> Removed:  Section on Set up the project and local interface
>> Removed:  using pip to install python modules
>> Removed: validation of html, unix formatting, no eol whitespace
>> Removed:  implied references to the port number used by toaster
>>
>> Can we put back some of the information that was removed at least wrt to
>> using the remote git repos or were there complaints from someone?
>>
>> Thanks,
>> Dave Lerner
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster