From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com,
wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com,
dgdegra@tycho.nsa.gov, jbeulich@suse.com, keir@xen.org
Cc: elena.ufimtseva@oracle.com, dario.faggioli@citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v6 2/5] sysctl: Add sysctl interface for querying PCI topology
Date: Tue, 07 Apr 2015 13:05:43 -0400 [thread overview]
Message-ID: <55240E67.1060005@oracle.com> (raw)
In-Reply-To: <5524013E.7010507@citrix.com>
On 04/07/2015 12:09 PM, Andrew Cooper wrote:
> On 06/04/15 23:12, Boris Ostrovsky wrote:
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> ---
>>
>> Changes in v6:
>> * Dropped continuations, the sysctl now returns after 64 iteration if necessary
> Why? The caller should reasonably expect a single hypercall to complete,
> not to have to reissue repeated to get all the data they want.
The caller is expected to restart from first_dev, not from beginning.
>
>> * -ENODEV returned if device is not found
> You don't actually break on -ENODEV, which causes the loop to continue
> to new devices and leave no hint as to which device doesn't exist.
Doh, I must have lost the break during various merges.
-boris
next prev parent reply other threads:[~2015-04-07 17:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 22:12 [PATCH v6 0/5] Display IO topology when PXM data is available (plus some cleanup) Boris Ostrovsky
2015-04-06 22:12 ` [PATCH v6 1/5] sysctl: Make XEN_SYSCTL_numainfo a little more efficient Boris Ostrovsky
2015-04-07 16:04 ` Andrew Cooper
2015-04-07 16:57 ` Boris Ostrovsky
2015-04-07 17:04 ` Andrew Cooper
2015-04-07 17:28 ` Boris Ostrovsky
2015-04-08 16:31 ` Andrew Cooper
2015-04-13 15:52 ` Jan Beulich
2015-04-15 12:29 ` Ian Campbell
2015-04-06 22:12 ` [PATCH v6 2/5] sysctl: Add sysctl interface for querying PCI topology Boris Ostrovsky
2015-04-07 16:09 ` Andrew Cooper
2015-04-07 17:05 ` Boris Ostrovsky [this message]
2015-04-07 17:22 ` Daniel De Graaf
2015-04-06 22:12 ` [PATCH v6 3/5] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc Boris Ostrovsky
2015-04-15 12:31 ` Ian Campbell
2015-04-06 22:12 ` [PATCH v6 4/5] libxl/libxc: Move libxl_get_numainfo()'s " Boris Ostrovsky
2015-04-15 12:33 ` Ian Campbell
2015-04-06 22:12 ` [PATCH v6 5/5] libxl: Add interface for querying hypervisor about PCI topology Boris Ostrovsky
2015-04-15 12:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55240E67.1060005@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=elena.ufimtseva@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.