All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Li, Wanpeng" <wanpeng.li@intel.com>
Subject: Re: [PATCH] kvm: fix slot flags sync between Qemu and KVM
Date: Wed, 08 Apr 2015 14:37:41 +0800	[thread overview]
Message-ID: <5524CCB5.7080102@linux.intel.com> (raw)
In-Reply-To: <5524CC0E.8020208@linux.intel.com>



On 04/08/2015 02:34 PM, Xiao Guangrong wrote:
> We noticed that KVM keeps tracking dirty for the memslots when
> live migration failed which causes bad performance due to huge
> page mapping disallowed for this kind of memslot
>
> It is caused by slot flags does not properly sync-ed between Qemu
> and KVM. Current code doing slot update depends on slot->flags
> which hopes to omit unnecessary ioctl. However, slot->flags only
> reflects the stauts of corresponding memory region, vmsave and
> live migration do dirty tracking which overset
> KVM_MEM_LOG_DIRTY_PAGES for the slot. That causes the slot status
> recorded in the flags does not exactly match the stauts in kernel.
>
> We fixed it by introducing slot->is_dirty_logging which indicates
> the dirty status in kernel so that it helps us to sync the status
> between userspace and kernel
>
> Wanpeng Li <wanpeng.li@linux.intel.com>

Sorry for the typo :( , this should be:

Reported-by: Wanpeng Li <wanpeng.li@linux.intel.com>

WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Li, Wanpeng" <wanpeng.li@intel.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] kvm: fix slot flags sync between Qemu and KVM
Date: Wed, 08 Apr 2015 14:37:41 +0800	[thread overview]
Message-ID: <5524CCB5.7080102@linux.intel.com> (raw)
In-Reply-To: <5524CC0E.8020208@linux.intel.com>



On 04/08/2015 02:34 PM, Xiao Guangrong wrote:
> We noticed that KVM keeps tracking dirty for the memslots when
> live migration failed which causes bad performance due to huge
> page mapping disallowed for this kind of memslot
>
> It is caused by slot flags does not properly sync-ed between Qemu
> and KVM. Current code doing slot update depends on slot->flags
> which hopes to omit unnecessary ioctl. However, slot->flags only
> reflects the stauts of corresponding memory region, vmsave and
> live migration do dirty tracking which overset
> KVM_MEM_LOG_DIRTY_PAGES for the slot. That causes the slot status
> recorded in the flags does not exactly match the stauts in kernel.
>
> We fixed it by introducing slot->is_dirty_logging which indicates
> the dirty status in kernel so that it helps us to sync the status
> between userspace and kernel
>
> Wanpeng Li <wanpeng.li@linux.intel.com>

Sorry for the typo :( , this should be:

Reported-by: Wanpeng Li <wanpeng.li@linux.intel.com>

  reply	other threads:[~2015-04-08  6:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08  6:34 [PATCH] kvm: fix slot flags sync between Qemu and KVM Xiao Guangrong
2015-04-08  6:34 ` [Qemu-devel] " Xiao Guangrong
2015-04-08  6:37 ` Xiao Guangrong [this message]
2015-04-08  6:37   ` Xiao Guangrong
2015-04-08 10:46 ` Paolo Bonzini
2015-04-08 10:46   ` [Qemu-devel] " Paolo Bonzini
2015-04-09  1:24   ` Xiao Guangrong
2015-04-09  1:24     ` [Qemu-devel] " Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5524CCB5.7080102@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wanpeng.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.