From: daniel.thompson@linaro.org (Daniel Thompson)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 4.0-rc5 v19 5/6] x86/nmi: Use common printk functions
Date: Wed, 08 Apr 2015 13:08:32 +0100 [thread overview]
Message-ID: <55251A40.5030105@linaro.org> (raw)
In-Reply-To: <20150407124307.58c7dd20@gandalf.local.home>
On 07/04/15 17:43, Steven Rostedt wrote:
> On Tue, 7 Apr 2015 18:37:46 +0200
> Borislav Petkov <bp@alien8.de> wrote:
>
>
>> I would simply say:
>>
>> err = printk_nmi_backtrace_prepare();
>> if (err)
>>
>> like sane kernel code does.
>>
>
> Yes, that is even the better solution.
Ok. I'll do this.
The constant on the left habit is so ingrained for me I often don't
notice it. I agree with Steven that modern compiler warnings render it
an obsolete habit...
Thanks.
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Russell King <linux@arm.linux.org.uk>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Stephen Boyd <sboyd@codeaurora.org>,
John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, patches@linaro.org,
linaro-kernel@lists.linaro.org,
Sumit Semwal <sumit.semwal@linaro.org>,
Dirk Behme <dirk.behme@de.bosch.com>,
Daniel Drake <drake@endlessm.com>,
Dmitry Pervushin <dpervushin@gmail.com>,
Tim Sander <tim@krieglstein.org>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [RESEND PATCH 4.0-rc5 v19 5/6] x86/nmi: Use common printk functions
Date: Wed, 08 Apr 2015 13:08:32 +0100 [thread overview]
Message-ID: <55251A40.5030105@linaro.org> (raw)
In-Reply-To: <20150407124307.58c7dd20@gandalf.local.home>
On 07/04/15 17:43, Steven Rostedt wrote:
> On Tue, 7 Apr 2015 18:37:46 +0200
> Borislav Petkov <bp@alien8.de> wrote:
>
>
>> I would simply say:
>>
>> err = printk_nmi_backtrace_prepare();
>> if (err)
>>
>> like sane kernel code does.
>>
>
> Yes, that is even the better solution.
Ok. I'll do this.
The constant on the left habit is so ingrained for me I often don't
notice it. I agree with Steven that modern compiler warnings render it
an obsolete habit...
Thanks.
Daniel.
next prev parent reply other threads:[~2015-04-08 12:08 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 16:53 [PATCH 4.0-rc5 v19 0/6] irq/arm: Implement arch_trigger_all_cpu_backtrace Daniel Thompson
2015-03-24 16:53 ` Daniel Thompson
2015-03-24 16:53 ` [PATCH 4.0-rc5 v19 1/6] irqchip: gic: Optimize locking in gic_raise_softirq Daniel Thompson
2015-03-24 16:53 ` Daniel Thompson
2015-03-24 16:53 ` [PATCH 4.0-rc5 v19 2/6] irqchip: gic: Make gic_raise_softirq FIQ-safe Daniel Thompson
2015-03-24 16:53 ` Daniel Thompson
2015-03-24 16:53 ` [PATCH 4.0-rc5 v19 3/6] irqchip: gic: Introduce plumbing for IPI FIQ Daniel Thompson
2015-03-24 16:53 ` Daniel Thompson
2015-03-24 16:53 ` [PATCH 4.0-rc5 v19 4/6] printk: Simple implementation for NMI backtracing Daniel Thompson
2015-03-24 16:53 ` Daniel Thompson
2015-03-24 16:53 ` [PATCH 4.0-rc5 v19 5/6] x86/nmi: Use common printk functions Daniel Thompson
2015-03-24 16:53 ` Daniel Thompson
2015-03-24 16:53 ` [PATCH 4.0-rc5 v19 6/6] ARM: Add support for on-demand backtrace of other CPUs Daniel Thompson
2015-03-24 16:53 ` Daniel Thompson
2015-04-07 15:37 ` [RESEND PATCH 4.0-rc5 v19 0/6] irq/arm: Implement arch_trigger_all_cpu_backtrace Daniel Thompson
2015-04-07 15:37 ` Daniel Thompson
2015-04-07 15:37 ` [RESEND PATCH 4.0-rc5 v19 1/6] irqchip: gic: Optimize locking in gic_raise_softirq Daniel Thompson
2015-04-07 15:37 ` Daniel Thompson
2015-04-07 15:37 ` [RESEND PATCH 4.0-rc5 v19 2/6] irqchip: gic: Make gic_raise_softirq FIQ-safe Daniel Thompson
2015-04-07 15:37 ` Daniel Thompson
2015-04-07 15:38 ` [RESEND PATCH 4.0-rc5 v19 3/6] irqchip: gic: Introduce plumbing for IPI FIQ Daniel Thompson
2015-04-07 15:38 ` Daniel Thompson
2015-04-07 15:38 ` [RESEND PATCH 4.0-rc5 v19 4/6] printk: Simple implementation for NMI backtracing Daniel Thompson
2015-04-07 15:38 ` Daniel Thompson
2015-04-07 15:38 ` [RESEND PATCH 4.0-rc5 v19 5/6] x86/nmi: Use common printk functions Daniel Thompson
2015-04-07 15:38 ` Daniel Thompson
2015-04-07 16:19 ` Steven Rostedt
2015-04-07 16:19 ` Steven Rostedt
2015-04-07 16:37 ` Borislav Petkov
2015-04-07 16:37 ` Borislav Petkov
2015-04-07 16:43 ` Steven Rostedt
2015-04-07 16:43 ` Steven Rostedt
2015-04-08 12:08 ` Daniel Thompson [this message]
2015-04-08 12:08 ` Daniel Thompson
2015-04-07 15:38 ` [RESEND PATCH 4.0-rc5 v19 6/6] ARM: Add support for on-demand backtrace of other CPUs Daniel Thompson
2015-04-07 15:38 ` Daniel Thompson
2015-04-10 9:51 ` [RESEND PATCH 4.0-rc7 v20 0/6] irq/arm: Implement arch_trigger_all_cpu_backtrace Daniel Thompson
2015-04-10 9:51 ` Daniel Thompson
2015-04-10 9:51 ` [RESEND PATCH 4.0-rc7 v20 1/6] irqchip: gic: Optimize locking in gic_raise_softirq Daniel Thompson
2015-04-10 9:51 ` Daniel Thompson
2015-04-21 12:51 ` Marc Zyngier
2015-04-21 12:51 ` Marc Zyngier
2015-04-10 9:51 ` [RESEND PATCH 4.0-rc7 v20 2/6] irqchip: gic: Make gic_raise_softirq FIQ-safe Daniel Thompson
2015-04-10 9:51 ` Daniel Thompson
2015-04-21 12:54 ` Marc Zyngier
2015-04-21 12:54 ` Marc Zyngier
2015-04-10 9:51 ` [RESEND PATCH 4.0-rc7 v20 3/6] irqchip: gic: Introduce plumbing for IPI FIQ Daniel Thompson
2015-04-10 9:51 ` Daniel Thompson
2015-04-21 13:45 ` Marc Zyngier
2015-04-21 13:45 ` Marc Zyngier
2015-04-21 21:03 ` Daniel Thompson
2015-04-21 21:03 ` Daniel Thompson
2015-04-22 9:15 ` Marc Zyngier
2015-04-22 9:15 ` Marc Zyngier
2015-04-22 12:45 ` Daniel Thompson
2015-04-22 12:45 ` Daniel Thompson
2015-04-22 12:57 ` Marc Zyngier
2015-04-22 12:57 ` Marc Zyngier
2015-04-22 15:40 ` Daniel Thompson
2015-04-22 15:40 ` Daniel Thompson
2015-04-21 14:50 ` Mark Rutland
2015-04-21 14:50 ` Mark Rutland
2015-04-21 21:15 ` Daniel Thompson
2015-04-21 21:15 ` Daniel Thompson
2015-04-22 10:38 ` Mark Rutland
2015-04-22 10:38 ` Mark Rutland
2015-07-02 13:31 ` Daniel Thompson
2015-07-02 13:31 ` Daniel Thompson
2015-04-10 9:51 ` [RESEND PATCH 4.0-rc7 v20 4/6] printk: Simple implementation for NMI backtracing Daniel Thompson
2015-04-10 9:51 ` Daniel Thompson
2015-04-10 9:51 ` [RESEND PATCH 4.0-rc7 v20 5/6] x86/nmi: Use common printk functions Daniel Thompson
2015-04-10 9:51 ` Daniel Thompson
2015-04-10 9:51 ` [RESEND PATCH 4.0-rc7 v20 6/6] ARM: Add support for on-demand backtrace of other CPUs Daniel Thompson
2015-04-10 9:51 ` Daniel Thompson
2015-04-10 10:47 ` [RESEND PATCH 4.0-rc7 v20 0/6] irq/arm: Implement arch_trigger_all_cpu_backtrace Daniel Thompson
2015-04-10 10:47 ` Daniel Thompson
2015-04-21 12:46 ` Thomas Gleixner
2015-04-21 12:46 ` Thomas Gleixner
2015-04-21 13:08 ` Marc Zyngier
2015-04-21 13:08 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55251A40.5030105@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.