From: Lars-Peter Clausen <lars@metafoo.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: ASoC: Failed to create DAPM debugfs
Date: Thu, 09 Apr 2015 09:39:09 +0200 [thread overview]
Message-ID: <55262C9D.5080005@metafoo.de> (raw)
In-Reply-To: <CAOMZO5AxT9dgE=QaH18FUYD5CbMvn67XpMo4dH6T0v9Qen-RRg@mail.gmail.com>
On 04/08/2015 10:35 PM, Fabio Estevam wrote:
> On Wed, Apr 8, 2015 at 4:33 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>
>> Does the card name contain a '/' like in 'S/PDIF'?
>
> Yes, it does. I also tried to change it like this:
>
> --- a/sound/soc/fsl/imx-spdif.c
> +++ b/sound/soc/fsl/imx-spdif.c
> @@ -37,8 +37,8 @@ static int imx_spdif_audio_probe(struct platform_device *pdev)
> goto end;
> }
>
> - data->dai.name = "S/PDIF PCM";
> - data->dai.stream_name = "S/PDIF PCM";
> + data->dai.name = "SPDIF PCM";
> + data->dai.stream_name = "SPDIF PCM";
> data->dai.codec_dai_name = "snd-soc-dummy-dai";
> data->dai.codec_name = "snd-soc-dummy";
> data->dai.cpu_of_node = spdif_np;
>
> ,but I still get the warning.
That's the DAI name, which could cause problems on its own. But not the one
you are seeing right now.
The whole thing is a bit confusing. The message you get is what you'd get if
the 'dapm' sub-directory in the card debugfs directory can not be created.
One of the few reasons why it would fail is if it already existed, but we
should never register two dapm contexts for the card, so that's a bit
strange. One of the few reasons I can imagine this could happen is if the
parent directory could not be created and now we try to create multiple dapm
directories at the top-level.
Try to do some more debugging and see why and where exactly things go wrong.
Can you also try this:
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index b6f8820..7810262 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1898,6 +1898,11 @@
{
struct dentry *d;
+ if (!parent) {
+ dev_warn(dapm->dev, "No debugfs parent!\n");
+ return;
+ }
+
dapm->debugfs_dapm = debugfs_create_dir("dapm", parent);
if (!dapm->debugfs_dapm) {
next prev parent reply other threads:[~2015-04-09 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 18:31 ASoC: Failed to create DAPM debugfs Fabio Estevam
2015-04-08 19:33 ` Lars-Peter Clausen
2015-04-08 20:35 ` Fabio Estevam
2015-04-09 7:39 ` Lars-Peter Clausen [this message]
2015-04-09 8:22 ` Nicolin Chen
2015-04-09 8:29 ` Lars-Peter Clausen
2015-04-09 8:45 ` Nicolin Chen
2015-04-09 8:55 ` Lars-Peter Clausen
2015-04-09 19:37 ` Nicolin Chen
2015-04-10 0:05 ` Fabio Estevam
2015-04-08 19:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55262C9D.5080005@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.