All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: ASoC: Failed to create DAPM debugfs
Date: Thu, 09 Apr 2015 10:29:39 +0200	[thread overview]
Message-ID: <55263873.108@metafoo.de> (raw)
In-Reply-To: <20150409082246.GB62585@Asurada-CZ80>

On 04/09/2015 10:22 AM, Nicolin Chen wrote:
> On Thu, Apr 09, 2015 at 09:39:09AM +0200, Lars-Peter Clausen wrote:
>
>> The whole thing is a bit confusing. The message you get is what
>> you'd get if the 'dapm' sub-directory in the card debugfs directory
>> can not be created. One of the few reasons why it would fail is if
>> it already existed, but we should never register two dapm contexts
>> for the card, so that's a bit strange. One of the few reasons I can
>> imagine this could happen is if the parent directory could not be
>> created and now we try to create multiple dapm directories at the
>> top-level.
>>
>> Try to do some more debugging and see why and where exactly things
>> go wrong. Can you also try this:
>>
>> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
>> index b6f8820..7810262 100644
>> --- a/sound/soc/soc-dapm.c
>> +++ b/sound/soc/soc-dapm.c
>> @@ -1898,6 +1898,11 @@
>>   {
>>   	struct dentry *d;
>>
>> +	if (!parent) {
>> +		dev_warn(dapm->dev, "No debugfs parent!\n");
>
> I tried, yes, the parent is NULL. And I did a little tracing and found
> that the card->debugfs_root, which is NULL, should be initialized in
> the soc_init_card_debugfs() while snd_soc_dapm_debugfs_init() seems
> to access this card->debugfs_root before calling soc_init_card_debugfs().
>
> I think I must have missed something over here....

Looks like this is the culprit: 
http://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=4e2576bd36a12e78ac3786d05b99a820dffe687f

  reply	other threads:[~2015-04-09  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 18:31 ASoC: Failed to create DAPM debugfs Fabio Estevam
2015-04-08 19:33 ` Lars-Peter Clausen
2015-04-08 20:35   ` Fabio Estevam
2015-04-09  7:39     ` Lars-Peter Clausen
2015-04-09  8:22       ` Nicolin Chen
2015-04-09  8:29         ` Lars-Peter Clausen [this message]
2015-04-09  8:45           ` Nicolin Chen
2015-04-09  8:55             ` Lars-Peter Clausen
2015-04-09 19:37               ` Nicolin Chen
2015-04-10  0:05                 ` Fabio Estevam
2015-04-08 19:44 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55263873.108@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux@arm.linux.org.uk \
    --cc=nicoleotsuka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.