From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Tim Deegan <tim@xen.org>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/6] x86/smp: Clean up use of memflags in cpu_smpboot_alloc()
Date: Thu, 9 Apr 2015 16:07:08 +0100 [thread overview]
Message-ID: <5526959C.2010003@citrix.com> (raw)
In-Reply-To: <20150409150221.GD34853@deinos.phlegethon.org>
On 09/04/15 16:02, Tim Deegan wrote:
> At 18:26 +0100 on 07 Apr (1428431177), Andrew Cooper wrote:
>> Hoist MEMF_node(cpu_to_node(cpu)) to the start of the function, and avoid
>> passing (potentially bogus) memflags if node information is not available.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> As it happens, MEMF_node(NUMA_NO_NODE) is already == 0.
Only because of a masked overflow. That is why (potentially) is in
brackets.
> I'm not sure if that's by design or not, but this looks robuster. :)
Indeed.
>
> Reviewed-by: Tim Deegan <tim@xen.org>
~Andrew
next prev parent reply other threads:[~2015-04-09 15:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 17:26 [PATCH 0/6] xen/x86: Misc x86 improvements Andrew Cooper
2015-04-07 17:26 ` [PATCH 1/6] x86/link: Discard the alternatives ".discard" sections Andrew Cooper
2015-04-09 14:58 ` Tim Deegan
2015-04-07 17:26 ` [PATCH 2/6] x86/numa: Correct the extern of cpu_to_node Andrew Cooper
2015-04-08 10:24 ` Dario Faggioli
2015-04-09 15:00 ` Tim Deegan
2015-04-09 15:05 ` Andrew Cooper
2015-04-09 15:18 ` Tim Deegan
2015-04-07 17:26 ` [PATCH 3/6] x86/smp: Clean up use of memflags in cpu_smpboot_alloc() Andrew Cooper
2015-04-08 10:15 ` Dario Faggioli
2015-04-09 15:02 ` Tim Deegan
2015-04-09 15:07 ` Andrew Cooper [this message]
2015-04-07 17:26 ` [PATCH 4/6] x86/link: Introduce and use __bss_end Andrew Cooper
2015-04-09 15:03 ` Tim Deegan
2015-04-07 17:26 ` [PATCH 5/6] x86/smp: Allocate pcpu stacks on their local numa node Andrew Cooper
2015-04-08 10:16 ` Dario Faggioli
2015-04-09 15:05 ` Tim Deegan
2015-04-07 17:26 ` [PATCH 6/6] x86/boot: Ensure the BSS is aligned on an 8 byte boundary Andrew Cooper
2015-04-09 15:15 ` Tim Deegan
2015-04-09 15:34 ` Andrew Cooper
2015-04-09 17:32 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5526959C.2010003@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.