Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

[Paolo Bonzini <pbonzini@redhat.com>]

On 09/04/2015 19:14, Bandan Das wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> ...
>> This breaks "QEMU=... ./x86-run ./x86/msr.flat"
>>
>> Fixed as follows:
>>
>> diff --git a/x86/run b/x86/run
>> index d5adf8d..219a93b 100755
>> --- a/x86/run
>> +++ b/x86/run
>> @@ -20,16 +20,15 @@ else
>>  		    break
>>  		fi
>>  	done
>> -fi
>> -
>> -if      [ -z "${QEMUFOUND}" ]
>> -then
>> -	echo "A QEMU binary was not found, You can set a custom location by using the QEMU=<path> environment variable "
>> -	exit ${NOTFOUND}
>> -elif    [ -z "${qemu}" ]
>> -then
>> -	echo "No Qemu test device support found"
>> -	exit ${TESTDEVNOTSUPP}
>> +	if      [ -z "${QEMUFOUND}" ]
>> +	then
>> +		echo "A QEMU binary was not found, You can set a custom location by using the QEMU=<path> environment variable "
>> +		exit ${NOTFOUND}
>> +	elif    [ -z "${qemu}" ]
>> +	then
>> +		echo "No Qemu test device support found"
> 
> I think we still want to print this if the user supplied qemu has no test
> device support.

Yes, but we do not go through the "for" in that case...

Can you make a patch on top of master?

Paolo