From: Bandan Das <bsd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found
Date: Thu, 09 Apr 2015 13:20:26 -0400 [thread overview]
Message-ID: <jpga8yhnrqd.fsf@redhat.com> (raw)
In-Reply-To: <jpgwq1lrzqb.fsf@redhat.com> (Bandan Das's message of "Thu, 09 Apr 2015 13:14:04 -0400")
Bandan Das <bsd@redhat.com> writes:
...
>
> I think we still want to print this if the user supplied qemu has no test
> device support. I think this is better -
> --- a/x86/run
> +++ b/x86/run
> @@ -8,6 +8,7 @@ qemusystem="${QEMU:-qemu-system-x86_64}"
> if ! [ -z "${QEMU}" ]
> then
> qemu="${QEMU}"
> + QEMUFOUND=1
> else
Damn, please ignore the previous message. This does nothing and I
need more sleep.
Bandan
> for qemucmds in ${qemukvm} ${qemusystem}
> do
>
>> + exit ${TESTDEVNOTSUPP}
>> + fi
>> fi
>>
>> if
>>
>> which apart from reindentation is just moving a "fi" down.
>> Paolo
prev parent reply other threads:[~2015-04-09 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 21:12 [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found Bandan Das
2015-04-02 12:47 ` Paolo Bonzini
2015-04-09 16:44 ` Paolo Bonzini
2015-04-09 17:14 ` Bandan Das
2015-04-09 17:17 ` Paolo Bonzini
2015-04-09 17:20 ` Bandan Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpga8yhnrqd.fsf@redhat.com \
--to=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.