Re: [PATCH] x86/Dom0: Don't allow dom0_max_vcpus to be zero

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 09/04/2015 21:38, Boris Ostrovsky wrote:
> In case dom0_max_vcpus is incorrectly specified on boot line make sure
> we will still boot.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Good catch - lets not do that.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  xen/arch/x86/domain_build.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c
> index e5c845c..378e650 100644
> --- a/xen/arch/x86/domain_build.c
> +++ b/xen/arch/x86/domain_build.c
> @@ -92,6 +92,8 @@ static void __init parse_dom0_max_vcpus(const char *s)
>      else                               /* N, N-, or N-M */
>      {
>          opt_dom0_max_vcpus_min = simple_strtoul(s, &s, 0);
> +        if ( opt_dom0_max_vcpus_min == 0 )
> +            opt_dom0_max_vcpus_min = 1;
>          if ( !*s )                    /* N */
>              opt_dom0_max_vcpus_max = opt_dom0_max_vcpus_min;
>          else if ( *s++ == '-' && *s ) /* N-M */