Re: [Qemu-devel] [PATCH 00/15] IPMI device for qemu

[Paolo Bonzini <pbonzini@redhat.com>]

On 07/04/2015 21:51, minyard@acm.org wrote:
> This set of patches adds an IPMI KCS or BT interface to qemu,
> along with a local simulated baseboard management controller (BMC)
> and a way to connect to an external BMC.  It is mostly unchanged
> from previous release, except for bug fixes and the following
> changes:
> 
> The ACPI generation code custom to this was removed and it's now
> using the new aml-build code.
> 
> Because of the previous change, capability was added to hook into
> the SSDT build process so that devices could insert their own
> table entries.
> 
> Also because of this, and because Benjamin Herrenschmidt pointed
> out the need to have this on systems without SMBIOS and ACPI, that
> code has now been made optional.  The SMBIOS uses TARGET_I386 to
> do this, which seems to be safe.  The ACPI code required
> transfering the CONFIG_ACPI entry from the default configs to the
> target configs, in a new patch (patch 13).  I'm not sure this was
> the best way, but adding a new file to do it got messy, and this
> seemed simple.  Maybe there's a better way.

I tried suggesting one in the reply to patch 13.

It requires splitting into three files (one for basic ISA IPMI, one for
SMBIOS, one for ACPI).

> Also, there's lots of config options for this, and I'm not sure they
> are really all necessary.  Should there be just one CONFIG_IPMI that
> covers everything?

I think it doesn't hurt to have more flexibility.

I didn't receive patch 15.

Paolo