From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Corey Minyard <cminyard@mvista.com>,
qemu-devel@nongnu.org, Corey Minyard <minyard@acm.org>
Subject: Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table
Date: Mon, 13 Apr 2015 15:47:56 +0200 [thread overview]
Message-ID: <552BC90C.7000201@redhat.com> (raw)
In-Reply-To: <20150413133153-mutt-send-email-mst@redhat.com>
On 13/04/2015 13:32, Michael S. Tsirkin wrote:
>>>> So you are suggesting each device add it's own SSDT? I'm not sure how
>>>> that helps debugging, it seems simpler to add it to a common one.
>>>
>>> For example, it's easier to write a unit test: encode something specific
>>> in one of the IDs, then look it up.
>>> Which is, btw, something that's missing in this patchset.
>>
>> A unit test for what?
>
> The ACPI code added. With an extra table it would be easy
> to test that it's there.
Ah, I agree that patch 15 should add something like commit
3a9c86df/71096d6c, but that doesn't need a separate table.
Paolo
next prev parent reply other threads:[~2015-04-13 13:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 19:51 [Qemu-devel] [PATCH 00/15] IPMI device for qemu minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 01/15] Add a base IPMI interface minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 02/15] ipmi: Add a PC ISA type structure minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 03/15] ipmi: Add a KCS low-level interface minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 04/15] ipmi: Add a BT " minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 05/15] ipmi: Add a local BMC simulation minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 06/15] ipmi: Add an external connection simulation interface minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 07/15] ipmi: Add tests minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 08/15] ipmi: Add documentation minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 09/15] ipmi: Add migration capability to the IPMI device minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry minyard
2015-04-12 16:05 ` Michael S. Tsirkin
2015-04-13 1:26 ` Corey Minyard
2015-04-13 7:00 ` Michael S. Tsirkin
2015-04-13 16:34 ` Corey Minyard
2015-04-13 16:40 ` Paolo Bonzini
2015-04-14 6:31 ` Michael S. Tsirkin
2015-04-14 15:30 ` Corey Minyard
2015-04-14 16:31 ` Paolo Bonzini
2015-04-14 6:41 ` Michael S. Tsirkin
2015-04-07 19:51 ` [Qemu-devel] [PATCH 11/15] pc: Postpone SMBIOS table installation to post machine init minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 12/15] ipmi: Add SMBIOS table entry minyard
2015-04-07 19:51 ` [Qemu-devel] [PATCH 13/15] configure: Copy some items from default configs to target configs minyard
2015-04-10 11:47 ` Paolo Bonzini
2015-04-07 19:51 ` [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table minyard
2015-04-10 11:29 ` Paolo Bonzini
2015-04-12 16:17 ` Michael S. Tsirkin
2015-04-13 1:30 ` Corey Minyard
2015-04-13 6:36 ` Michael S. Tsirkin
2015-04-13 8:39 ` Paolo Bonzini
2015-04-13 11:32 ` Michael S. Tsirkin
2015-04-13 13:47 ` Paolo Bonzini [this message]
2015-04-13 13:44 ` Paolo Bonzini
2015-04-13 16:00 ` Corey Minyard
2015-04-13 16:41 ` Paolo Bonzini
2015-04-10 11:48 ` [Qemu-devel] [PATCH 00/15] IPMI device for qemu Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552BC90C.7000201@redhat.com \
--to=pbonzini@redhat.com \
--cc=cminyard@mvista.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.