From: a.ryabinin@samsung.com (Andrey Ryabinin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: add KASan support
Date: Fri, 10 Apr 2015 16:37:50 +0300 [thread overview]
Message-ID: <5527D22E.9090000@samsung.com> (raw)
In-Reply-To: <8790947.ikOtIjWHkt@wuerfel>
On 04/10/2015 04:02 PM, Arnd Bergmann wrote:
> On Friday 10 April 2015 13:48:52 Andrey Ryabinin wrote:
>> On 04/09/2015 11:17 PM, Arnd Bergmann wrote:
>>> On Tuesday 24 March 2015 17:49:04 Andrey Ryabinin wrote:
>>>> arch/arm64/mm/kasan_init.c | 211 +++++++++++++++++++++++++++++++++++
>>>>
>>>
>>> Just one very high-level question: as this code is clearly derived from
>>> the x86 version and nontrivial, could we move most of it out of
>>> arch/{x86,arm64} into mm/kasan/init.c and have the rest in some header
>>> file?
>>>
>>
>> I think most of this could be moved out from arch code, but not everything.
>> E.g. kasan_init() function is too arch-specific.
>
> Right, makes sense. So presumably, populate_zero_shadow could become a global
> function by another name, and possibly also handle registering the die
> handler, so you can call it from an architecture specific kasan_init()
> function, right?
>
Yep, you are right.
> Arnd
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] arm64: add KASan support
Date: Fri, 10 Apr 2015 16:37:50 +0300 [thread overview]
Message-ID: <5527D22E.9090000@samsung.com> (raw)
In-Reply-To: <8790947.ikOtIjWHkt@wuerfel>
On 04/10/2015 04:02 PM, Arnd Bergmann wrote:
> On Friday 10 April 2015 13:48:52 Andrey Ryabinin wrote:
>> On 04/09/2015 11:17 PM, Arnd Bergmann wrote:
>>> On Tuesday 24 March 2015 17:49:04 Andrey Ryabinin wrote:
>>>> arch/arm64/mm/kasan_init.c | 211 +++++++++++++++++++++++++++++++++++
>>>>
>>>
>>> Just one very high-level question: as this code is clearly derived from
>>> the x86 version and nontrivial, could we move most of it out of
>>> arch/{x86,arm64} into mm/kasan/init.c and have the rest in some header
>>> file?
>>>
>>
>> I think most of this could be moved out from arch code, but not everything.
>> E.g. kasan_init() function is too arch-specific.
>
> Right, makes sense. So presumably, populate_zero_shadow could become a global
> function by another name, and possibly also handle registering the die
> handler, so you can call it from an architecture specific kasan_init()
> function, right?
>
Yep, you are right.
> Arnd
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] arm64: add KASan support
Date: Fri, 10 Apr 2015 16:37:50 +0300 [thread overview]
Message-ID: <5527D22E.9090000@samsung.com> (raw)
In-Reply-To: <8790947.ikOtIjWHkt@wuerfel>
On 04/10/2015 04:02 PM, Arnd Bergmann wrote:
> On Friday 10 April 2015 13:48:52 Andrey Ryabinin wrote:
>> On 04/09/2015 11:17 PM, Arnd Bergmann wrote:
>>> On Tuesday 24 March 2015 17:49:04 Andrey Ryabinin wrote:
>>>> arch/arm64/mm/kasan_init.c | 211 +++++++++++++++++++++++++++++++++++
>>>>
>>>
>>> Just one very high-level question: as this code is clearly derived from
>>> the x86 version and nontrivial, could we move most of it out of
>>> arch/{x86,arm64} into mm/kasan/init.c and have the rest in some header
>>> file?
>>>
>>
>> I think most of this could be moved out from arch code, but not everything.
>> E.g. kasan_init() function is too arch-specific.
>
> Right, makes sense. So presumably, populate_zero_shadow could become a global
> function by another name, and possibly also handle registering the die
> handler, so you can call it from an architecture specific kasan_init()
> function, right?
>
Yep, you are right.
> Arnd
>
next prev parent reply other threads:[~2015-04-10 13:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 14:49 [PATCH 0/2] KASan for arm64 Andrey Ryabinin
2015-03-24 14:49 ` Andrey Ryabinin
2015-03-24 14:49 ` Andrey Ryabinin
2015-03-24 14:49 ` [PATCH 1/2] kasan, x86: move KASAN_SHADOW_OFFSET to the arch Kconfig Andrey Ryabinin
2015-03-24 14:49 ` Andrey Ryabinin
2015-03-24 14:49 ` Andrey Ryabinin
2015-03-24 14:49 ` [PATCH 2/2] arm64: add KASan support Andrey Ryabinin
2015-03-24 14:49 ` Andrey Ryabinin
2015-03-24 14:49 ` Andrey Ryabinin
2015-04-01 12:28 ` Catalin Marinas
2015-04-01 12:28 ` Catalin Marinas
2015-04-01 12:28 ` Catalin Marinas
2015-04-03 13:44 ` Andrey Ryabinin
2015-04-03 13:44 ` Andrey Ryabinin
2015-04-03 13:44 ` Andrey Ryabinin
2015-04-15 2:37 ` David Keitel
2015-04-15 2:37 ` David Keitel
2015-04-15 2:37 ` David Keitel
2015-04-15 18:04 ` Andrey Ryabinin
2015-04-15 18:04 ` Andrey Ryabinin
2015-04-15 18:04 ` Andrey Ryabinin
2015-04-17 18:39 ` David Keitel
2015-04-17 18:39 ` David Keitel
2015-04-17 18:39 ` David Keitel
2015-04-20 6:48 ` Andrey Ryabinin
2015-04-20 6:48 ` Andrey Ryabinin
2015-04-20 6:48 ` Andrey Ryabinin
2015-04-09 20:17 ` Arnd Bergmann
2015-04-09 20:17 ` Arnd Bergmann
2015-04-09 20:17 ` Arnd Bergmann
2015-04-10 10:48 ` Andrey Ryabinin
2015-04-10 10:48 ` Andrey Ryabinin
2015-04-10 10:48 ` Andrey Ryabinin
2015-04-10 13:02 ` Arnd Bergmann
2015-04-10 13:02 ` Arnd Bergmann
2015-04-10 13:02 ` Arnd Bergmann
2015-04-10 13:37 ` Andrey Ryabinin [this message]
2015-04-10 13:37 ` Andrey Ryabinin
2015-04-10 13:37 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5527D22E.9090000@samsung.com \
--to=a.ryabinin@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.