All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 1/8] Add core.sh and wrapper function
Date: Mon, 13 Apr 2015 11:23:57 +0100	[thread overview]
Message-ID: <552B993D.1080700@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1504101154020.7690@kaball.uk.xensource.com>

On 04/10/2015 03:29 PM, Stefano Stabellini wrote:
>> diff --git a/raise b/raise
>> new file mode 100755
>> index 0000000..7f3faae
>> --- /dev/null
>> +++ b/raise
>> @@ -0,0 +1,16 @@
>> +#!/usr/bin/env bash
> 
> It is important to "set -e" immediately to catch all possible errors:
> 
>  "-e  Exit immediately if a command exits with a non-zero status."
> 
> Then you can drop set -e from raise.sh and unraise.sh when you turn them
> into libraries.

"set -e" gets tricky when you sometimes expect commands to fail;
particularly if you may want to do some sort of clean-up.  But let's
cross that bridge when we come to it. :-)

 -George

  reply	other threads:[~2015-04-13 10:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 19:29 raisin: Refactor to be more like a library George Dunlap
2015-04-09 19:29 ` [PATCH 1/8] Add core.sh and wrapper function George Dunlap
2015-04-09 19:40   ` George Dunlap
2015-04-10 14:30     ` Stefano Stabellini
2015-04-10 14:29   ` Stefano Stabellini
2015-04-13 10:23     ` George Dunlap [this message]
2015-04-13 10:41     ` George Dunlap
2015-04-13 16:13       ` Stefano Stabellini
2015-04-14 13:55         ` Ian Campbell
2015-04-14 14:44           ` George Dunlap
2015-04-15  8:29             ` Ian Campbell
2015-04-09 19:29 ` [PATCH 2/8] Remove redundant "source" from component definitions George Dunlap
2015-04-10 11:05   ` Stefano Stabellini
2015-04-09 19:29 ` [PATCH 3/8] Move common-functions.sh and git-checkout.sh into lib George Dunlap
2015-04-10 11:05   ` Stefano Stabellini
2015-04-09 19:29 ` [PATCH 4/8] Import raise.sh and unraise.sh into library George Dunlap
2015-04-10 14:29   ` Stefano Stabellini
2015-04-09 19:29 ` [PATCH 5/8] Allow the user's config to live outside of git George Dunlap
2015-04-10 14:30   ` Stefano Stabellini
2015-04-09 19:29 ` [PATCH 6/8] xen: Replace iasl with acpica-tools George Dunlap
2015-04-10 11:05   ` Stefano Stabellini
2015-04-09 19:29 ` [PATCH 7/8] xen: Require wget George Dunlap
2015-04-10 11:06   ` Stefano Stabellini
2015-04-09 19:29 ` [PATCH 8/8] Refactor package dependency checking and installation George Dunlap
2015-04-10 14:30   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552B993D.1080700@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.