All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] microblaze: Fix EMAC Lite initialization
@ 2015-04-14  6:16 Nathan Rossi
  2015-04-15  5:49 ` Michal Simek
  0 siblings, 1 reply; 2+ messages in thread
From: Nathan Rossi @ 2015-04-14  6:16 UTC (permalink / raw)
  To: u-boot

It is possible for CONFIG_XILINX_EMACLITE to be defined without
XILINX_EMACLITE_BASEADDR being defined as the EMAC Lite driver support
OF init. Check that the driver is enabled and the base address is
available before initializing with a static base address.

Signed-off-by: Nathan Rossi <nathan.rossi@xilinx.com>
---
 board/xilinx/microblaze-generic/microblaze-generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/xilinx/microblaze-generic/microblaze-generic.c b/board/xilinx/microblaze-generic/microblaze-generic.c
index 3110405..375cd0b 100644
--- a/board/xilinx/microblaze-generic/microblaze-generic.c
+++ b/board/xilinx/microblaze-generic/microblaze-generic.c
@@ -109,7 +109,7 @@ int board_eth_init(bd_t *bis)
 						XILINX_AXIDMA_BASEADDR);
 #endif
 
-#ifdef CONFIG_XILINX_EMACLITE
+#if defined(CONFIG_XILINX_EMACLITE) && defined(XILINX_EMACLITE_BASEADDR)
 	u32 txpp = 0;
 	u32 rxpp = 0;
 # ifdef CONFIG_XILINX_EMACLITE_TX_PING_PONG
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] microblaze: Fix EMAC Lite initialization
  2015-04-14  6:16 [U-Boot] [PATCH] microblaze: Fix EMAC Lite initialization Nathan Rossi
@ 2015-04-15  5:49 ` Michal Simek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2015-04-15  5:49 UTC (permalink / raw)
  To: u-boot

On 04/14/2015 08:16 AM, Nathan Rossi wrote:
> It is possible for CONFIG_XILINX_EMACLITE to be defined without
> XILINX_EMACLITE_BASEADDR being defined as the EMAC Lite driver support
> OF init. Check that the driver is enabled and the base address is
> available before initializing with a static base address.
> 
> Signed-off-by: Nathan Rossi <nathan.rossi@xilinx.com>
> ---
>  board/xilinx/microblaze-generic/microblaze-generic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/xilinx/microblaze-generic/microblaze-generic.c b/board/xilinx/microblaze-generic/microblaze-generic.c
> index 3110405..375cd0b 100644
> --- a/board/xilinx/microblaze-generic/microblaze-generic.c
> +++ b/board/xilinx/microblaze-generic/microblaze-generic.c
> @@ -109,7 +109,7 @@ int board_eth_init(bd_t *bis)
>  						XILINX_AXIDMA_BASEADDR);
>  #endif
>  
> -#ifdef CONFIG_XILINX_EMACLITE
> +#if defined(CONFIG_XILINX_EMACLITE) && defined(XILINX_EMACLITE_BASEADDR)
>  	u32 txpp = 0;
>  	u32 rxpp = 0;
>  # ifdef CONFIG_XILINX_EMACLITE_TX_PING_PONG
> 

Applied.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150415/96d206fb/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-15  5:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-14  6:16 [U-Boot] [PATCH] microblaze: Fix EMAC Lite initialization Nathan Rossi
2015-04-15  5:49 ` Michal Simek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.