From: Suzuki.Poulose@arm.com (Suzuki K. Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] drivers: CCI: fix used_mask init in validate_group()
Date: Wed, 15 Apr 2015 11:44:06 +0100 [thread overview]
Message-ID: <552E40F6.1010504@arm.com> (raw)
In-Reply-To: <1428591425-17330-1-git-send-email-msalter@redhat.com>
On 09/04/15 15:57, Mark Salter wrote:
> Currently in validate_group(), there is a static initializer
> for fake_pmu.used_mask which is based on CPU_BITS_NONE but
> the used_mask array size is based on CCI_PMU_MAX_HW_EVENTS.
> CCI_PMU_MAX_HW_EVENTS is not based on NR_CPUS, so CPU_BITS_NONE
> is not correct and will cause a build failure if NR_CPUS
> is set high enough to make CPU_BITS_NONE larger than used_mask.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
> ---
> drivers/bus/arm-cci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 84fd660..759e41c 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -684,7 +684,7 @@ validate_group(struct perf_event *event)
> * Initialise the fake PMU. We only need to populate the
> * used_mask for the purposes of validation.
> */
> - .used_mask = CPU_BITS_NONE,
> + .used_mask = { 0 },
> };
>
> if (!validate_event(&fake_pmu, leader))
>
I have a series of patches to add CCI-500 PMU, targeting 4.2, which
changes the used_mask to a pointer and changes it to depend on the
number of counters available on the CCI PMU. I will post it in very
soon here, which could make this patch obsolete. Let me know if you
don't mind getting this sorted out through my series. I am fine either way.
Regards
Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
To: Mark Salter <msalter@redhat.com>, Will Deacon <Will.Deacon@arm.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] drivers: CCI: fix used_mask init in validate_group()
Date: Wed, 15 Apr 2015 11:44:06 +0100 [thread overview]
Message-ID: <552E40F6.1010504@arm.com> (raw)
In-Reply-To: <1428591425-17330-1-git-send-email-msalter@redhat.com>
On 09/04/15 15:57, Mark Salter wrote:
> Currently in validate_group(), there is a static initializer
> for fake_pmu.used_mask which is based on CPU_BITS_NONE but
> the used_mask array size is based on CCI_PMU_MAX_HW_EVENTS.
> CCI_PMU_MAX_HW_EVENTS is not based on NR_CPUS, so CPU_BITS_NONE
> is not correct and will cause a build failure if NR_CPUS
> is set high enough to make CPU_BITS_NONE larger than used_mask.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
> ---
> drivers/bus/arm-cci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 84fd660..759e41c 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -684,7 +684,7 @@ validate_group(struct perf_event *event)
> * Initialise the fake PMU. We only need to populate the
> * used_mask for the purposes of validation.
> */
> - .used_mask = CPU_BITS_NONE,
> + .used_mask = { 0 },
> };
>
> if (!validate_event(&fake_pmu, leader))
>
I have a series of patches to add CCI-500 PMU, targeting 4.2, which
changes the used_mask to a pointer and changes it to depend on the
number of counters available on the CCI PMU. I will post it in very
soon here, which could make this patch obsolete. Let me know if you
don't mind getting this sorted out through my series. I am fine either way.
Regards
Suzuki
next prev parent reply other threads:[~2015-04-15 10:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 18:21 [PATCH] drivers: CCI: fix used_mask init in validate_group() Mark Salter
2015-04-08 18:21 ` Mark Salter
2015-04-09 11:06 ` Suzuki K. Poulose
2015-04-09 11:06 ` Suzuki K. Poulose
2015-04-09 13:51 ` Mark Rutland
2015-04-09 13:51 ` Mark Rutland
2015-04-09 14:11 ` Mark Salter
2015-04-09 14:11 ` Mark Salter
2015-04-09 14:20 ` Mark Rutland
2015-04-09 14:20 ` Mark Rutland
2015-04-09 14:26 ` Mark Salter
2015-04-09 14:26 ` Mark Salter
2015-04-09 14:40 ` Mark Rutland
2015-04-09 14:40 ` Mark Rutland
2015-04-09 14:57 ` [PATCH V2] " Mark Salter
2015-04-09 14:57 ` Mark Salter
2015-04-09 15:36 ` Mark Rutland
2015-04-09 15:36 ` Mark Rutland
2015-04-13 12:41 ` Will Deacon
2015-04-13 12:41 ` Will Deacon
2015-04-30 10:55 ` Suzuki K. Poulose
2015-04-30 10:55 ` Suzuki K. Poulose
2015-04-30 13:26 ` Mark Salter
2015-04-30 13:26 ` Mark Salter
2015-04-30 13:33 ` Mark Rutland
2015-04-30 13:33 ` Mark Rutland
2015-04-30 14:03 ` Mark Salter
2015-04-30 14:03 ` Mark Salter
2015-04-30 14:38 ` Mark Rutland
2015-04-30 14:38 ` Mark Rutland
2015-04-30 14:46 ` Mark Salter
2015-04-30 14:46 ` Mark Salter
2015-04-30 14:52 ` Arnd Bergmann
2015-04-30 14:52 ` Arnd Bergmann
2015-04-15 10:44 ` Suzuki K. Poulose [this message]
2015-04-15 10:44 ` Suzuki K. Poulose
2015-04-15 11:58 ` Will Deacon
2015-04-15 11:58 ` Will Deacon
2015-04-15 12:50 ` Suzuki K. Poulose
2015-04-15 12:50 ` Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E40F6.1010504@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.