* [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
@ 2015-04-16 12:18 ` weiyj_lk at 163.com
0 siblings, 0 replies; 8+ messages in thread
From: weiyj_lk at 163.com @ 2015-04-16 12:18 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function devm_ioremap_resource() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c
index 326d3c3..5bf7236 100644
--- a/sound/soc/samsung/s3c24xx-i2s.c
+++ b/sound/soc/samsung/s3c24xx-i2s.c
@@ -461,8 +461,8 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev)
return -ENOENT;
}
s3c24xx_i2s.regs = devm_ioremap_resource(&pdev->dev, res);
- if (s3c24xx_i2s.regs == NULL)
- return -ENXIO;
+ if (IS_ERR(s3c24xx_i2s.regs))
+ return PTR_ERR(s3c24xx_i2s.regs);
s3c24xx_i2s_pcm_stereo_out.dma_addr = res->start + S3C2410_IISFIFO;
s3c24xx_i2s_pcm_stereo_in.dma_addr = res->start + S3C2410_IISFIFO;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
2015-04-16 12:18 ` weiyj_lk at 163.com
@ 2015-04-16 12:24 ` Krzysztof Kozłowski
-1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozłowski @ 2015-04-16 12:24 UTC (permalink / raw)
To: weiyj_lk
Cc: Kukjin Kim, Sangbeom Kim, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Wei Yongjun, linux-samsung-soc,
alsa-devel, linux-arm-kernel
2015-04-16 21:18 GMT+09:00 <weiyj_lk@163.com>:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
@ 2015-04-16 12:24 ` Krzysztof Kozłowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozłowski @ 2015-04-16 12:24 UTC (permalink / raw)
To: linux-arm-kernel
2015-04-16 21:18 GMT+09:00 <weiyj_lk@163.com>:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
2015-04-16 12:18 ` weiyj_lk at 163.com
@ 2015-04-16 12:35 ` Varka Bhadram
-1 siblings, 0 replies; 8+ messages in thread
From: Varka Bhadram @ 2015-04-16 12:35 UTC (permalink / raw)
To: weiyj_lk, Kukjin Kim, Sangbeom Kim, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai
Cc: Wei Yongjun, linux-arm-kernel, linux-samsung-soc, alsa-devel
On 04/16/2015 05:48 PM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
This bug is there in other drivers in sound/soc/samsung/
Try do for all the drivers.
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c
> index 326d3c3..5bf7236 100644
> --- a/sound/soc/samsung/s3c24xx-i2s.c
> +++ b/sound/soc/samsung/s3c24xx-i2s.c
> @@ -461,8 +461,8 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev)
> return -ENOENT;
> }
> s3c24xx_i2s.regs = devm_ioremap_resource(&pdev->dev, res);
> - if (s3c24xx_i2s.regs == NULL)
> - return -ENXIO;
> + if (IS_ERR(s3c24xx_i2s.regs))
> + return PTR_ERR(s3c24xx_i2s.regs);
>
> s3c24xx_i2s_pcm_stereo_out.dma_addr = res->start + S3C2410_IISFIFO;
> s3c24xx_i2s_pcm_stereo_in.dma_addr = res->start + S3C2410_IISFIFO;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Varka Bhadram
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
@ 2015-04-16 12:35 ` Varka Bhadram
0 siblings, 0 replies; 8+ messages in thread
From: Varka Bhadram @ 2015-04-16 12:35 UTC (permalink / raw)
To: linux-arm-kernel
On 04/16/2015 05:48 PM, weiyj_lk at 163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
This bug is there in other drivers in sound/soc/samsung/
Try do for all the drivers.
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c
> index 326d3c3..5bf7236 100644
> --- a/sound/soc/samsung/s3c24xx-i2s.c
> +++ b/sound/soc/samsung/s3c24xx-i2s.c
> @@ -461,8 +461,8 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev)
> return -ENOENT;
> }
> s3c24xx_i2s.regs = devm_ioremap_resource(&pdev->dev, res);
> - if (s3c24xx_i2s.regs == NULL)
> - return -ENXIO;
> + if (IS_ERR(s3c24xx_i2s.regs))
> + return PTR_ERR(s3c24xx_i2s.regs);
>
> s3c24xx_i2s_pcm_stereo_out.dma_addr = res->start + S3C2410_IISFIFO;
> s3c24xx_i2s_pcm_stereo_in.dma_addr = res->start + S3C2410_IISFIFO;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Varka Bhadram
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
2015-04-16 12:18 ` weiyj_lk at 163.com
@ 2015-04-17 13:23 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2015-04-17 13:23 UTC (permalink / raw)
To: weiyj_lk
Cc: Kukjin Kim, Sangbeom Kim, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Wei Yongjun, linux-arm-kernel, linux-samsung-soc,
alsa-devel
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Thu, Apr 16, 2015 at 08:18:02PM +0800, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread