All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jing Zhang <renyu.zj@linux.alibaba.com>
To: John Garry <john.g.garry@oracle.com>,
	Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Robin Murphy <robin.murphy@arm.com>
Cc: James Clark <james.clark@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ilkka Koskinen <ilkka@os.amperecomputing.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,
	Zhuo Song <zhuo.song@linux.alibaba.com>
Subject: Re: [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers
Date: Thu, 15 Jun 2023 10:18:01 +0800	[thread overview]
Message-ID: <552eebae-76bb-a2fe-ccdc-11e8a01717da@linux.alibaba.com> (raw)
In-Reply-To: <079d7920-2030-2e00-a833-5ec6d450f7dc@oracle.com>



在 2023/6/14 上午12:36, John Garry 写道:
> On 12/06/2023 19:15, John Garry wrote:
>> On 08/06/2023 10:44, Jing Zhang wrote:
>>>> Unit is the format of the event_source device name. We should match based on that as well as compat. I need to check the code again to understand how that is done... it has changed a good bit in 3 years.
>>>>
>>> This situation only happens on uncore metric. I happened to write wrong Unit, but the metric still matches.
>>>
>>
>> I'm just double checking this now. I think any possible fix should be easy enough for current code but may be tricky for backport with lots of metric code changes.
> 
> I also have code to re-work sys event metric support such that we don't require "compat" or "Unit" values for a metric when the metric is described in terms of event aliases. That code is 2 years old, so may take a bit of time to rebase. I'll look to do that now.
> 

Sounds good!

Thanks,
Jing


> Thanks,
> John
> 

WARNING: multiple messages have this Message-ID (diff)
From: Jing Zhang <renyu.zj@linux.alibaba.com>
To: John Garry <john.g.garry@oracle.com>,
	Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Robin Murphy <robin.murphy@arm.com>
Cc: James Clark <james.clark@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ilkka Koskinen <ilkka@os.amperecomputing.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,
	Zhuo Song <zhuo.song@linux.alibaba.com>
Subject: Re: [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers
Date: Thu, 15 Jun 2023 10:18:01 +0800	[thread overview]
Message-ID: <552eebae-76bb-a2fe-ccdc-11e8a01717da@linux.alibaba.com> (raw)
In-Reply-To: <079d7920-2030-2e00-a833-5ec6d450f7dc@oracle.com>



在 2023/6/14 上午12:36, John Garry 写道:
> On 12/06/2023 19:15, John Garry wrote:
>> On 08/06/2023 10:44, Jing Zhang wrote:
>>>> Unit is the format of the event_source device name. We should match based on that as well as compat. I need to check the code again to understand how that is done... it has changed a good bit in 3 years.
>>>>
>>> This situation only happens on uncore metric. I happened to write wrong Unit, but the metric still matches.
>>>
>>
>> I'm just double checking this now. I think any possible fix should be easy enough for current code but may be tricky for backport with lots of metric code changes.
> 
> I also have code to re-work sys event metric support such that we don't require "compat" or "Unit" values for a metric when the metric is described in terms of event aliases. That code is 2 years old, so may take a bit of time to rebase. I'll look to do that now.
> 

Sounds good!

Thanks,
Jing


> Thanks,
> John
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-15  2:18 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  9:19 [PATCH v3 0/7] Add JSON metrics for arm CMN and Yitian710 DDR Jing Zhang
2023-05-30  9:19 ` Jing Zhang
2023-05-30  9:19 ` [PATCH v3 1/7] driver/perf: Add identifier sysfs file for CMN Jing Zhang
2023-05-30  9:19   ` Jing Zhang
2023-05-31  2:58   ` kernel test robot
2023-05-31  2:58     ` kernel test robot
2023-05-30  9:19 ` [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers Jing Zhang
2023-05-30  9:19   ` Jing Zhang
2023-05-31 13:18   ` John Garry
2023-05-31 13:18     ` John Garry
2023-06-01  8:58     ` Jing Zhang
2023-06-01  8:58       ` Jing Zhang
2023-06-02 16:20       ` John Garry
2023-06-02 16:20         ` John Garry
2023-06-05  2:46         ` Jing Zhang
2023-06-05  2:46           ` Jing Zhang
2023-06-05 19:39           ` Arnaldo Carvalho de Melo
2023-06-05 19:39             ` Arnaldo Carvalho de Melo
2023-06-15  3:41             ` Jing Zhang
2023-06-15  3:41               ` Jing Zhang
2023-06-23 23:52               ` Namhyung Kim
2023-06-23 23:52                 ` Namhyung Kim
2023-06-25  8:55                 ` Jing Zhang
2023-06-25  8:55                   ` Jing Zhang
2023-06-06 14:11           ` John Garry
2023-06-06 14:11             ` John Garry
2023-06-08  9:44             ` Jing Zhang
2023-06-08  9:44               ` Jing Zhang
2023-06-12 18:15               ` John Garry
2023-06-12 18:15                 ` John Garry
2023-06-13 16:36                 ` John Garry
2023-06-13 16:36                   ` John Garry
2023-06-15  2:18                   ` Jing Zhang [this message]
2023-06-15  2:18                     ` Jing Zhang
2023-06-16 11:41                     ` John Garry
2023-06-16 11:41                       ` John Garry
2023-06-19  2:58                       ` Jing Zhang
2023-06-19  2:58                         ` Jing Zhang
2023-06-19  7:07                         ` John Garry
2023-06-19  7:07                           ` John Garry
2023-06-19  8:59                           ` Jing Zhang
2023-06-19  8:59                             ` Jing Zhang
2023-06-19  9:31                             ` John Garry
2023-06-19  9:31                               ` John Garry
2023-06-20  2:12                               ` Jing Zhang
2023-06-20  2:12                                 ` Jing Zhang
2023-06-20  7:01                                 ` John Garry
2023-06-20  7:01                                   ` John Garry
2023-06-21  3:15                                   ` Jing Zhang
2023-06-21  3:15                                     ` Jing Zhang
2023-06-06 16:27         ` Robin Murphy
2023-06-06 16:27           ` Robin Murphy
2023-06-08 10:11           ` Jing Zhang
2023-06-08 10:11             ` Jing Zhang
2023-05-30  9:19 ` [PATCH v3 3/7] perf vendor events: Add JSON metrics for CMN Jing Zhang
2023-05-30  9:19   ` Jing Zhang
2023-05-31  1:18   ` Ian Rogers
2023-05-31  1:18     ` Ian Rogers
2023-06-01  9:03     ` Jing Zhang
2023-06-01  9:03       ` Jing Zhang
2023-05-31  2:43   ` Shuai Xue
2023-05-31  2:43     ` Shuai Xue
2023-06-01  9:06     ` Jing Zhang
2023-06-01  9:06       ` Jing Zhang
2023-05-30  9:19 ` [PATCH v3 4/7] driver/perf: Add identifier sysfs file for Yitian 710 DDR Jing Zhang
2023-05-30  9:19   ` Jing Zhang
2023-05-30  9:19 ` [PATCH v3 5/7] perf jevents: Add support for Yitian 710 DDR PMU aliasing Jing Zhang
2023-05-30  9:19   ` Jing Zhang
2023-05-30  9:19 ` [PATCH v3 6/7] perf vendor events: Add JSON metrics for Yitian 710 DDR Jing Zhang
2023-05-30  9:19   ` Jing Zhang
2023-05-30  9:19 ` [PATCH v3 7/7] docs: perf: Update metric usage for Alibaba's T-Head PMU driver Jing Zhang
2023-05-30  9:19   ` Jing Zhang
2023-05-31  1:19   ` Ian Rogers
2023-05-31  1:19     ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552eebae-76bb-a2fe-ccdc-11e8a01717da@linux.alibaba.com \
    --to=renyu.zj@linux.alibaba.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ilkka@os.amperecomputing.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=namhyung@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=zhuo.song@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.