From: Jim Fehlig <jfehlig@suse.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 0/3] libxl: fd events: Recheck with poll
Date: Thu, 16 Apr 2015 15:19:27 -0600 [thread overview]
Message-ID: <5530275F.4040902@suse.com> (raw)
In-Reply-To: <1429208608-6185-1-git-send-email-ian.jackson@eu.citrix.com>
On 04/16/2015 12:23 PM, Ian Jackson wrote:
> Ian:
>>> Jim:
>>> I too saw this bug just before Konrad's report, but the patches
>>> don't seem to\
>>> help. Running a script that continually saves and restores domains will
>>> eventually lock libvirtd with essentially the same traces reported by Konrad
>> I'm a total idiot. I do the recheck but I don't pay any attention to
>> the result.
> Sorry to waste your time. Now fixed, I hope.
>
>> Having slept on this I wonder if it might be better to always do this
>> recheck in the event core before making the fd callback. The current
>> semantics are a bit of a gotcha.
> And this, done. These 3 patches are entirely different to the last
> attempt.
>
> Again, compiled but not tested.
I tested the v2 patches and no longer see the problem. I didn't review them
closely, so ATM can only add
Tested-by: Jim Fehlig <jfehlig@suse.com>
Thanks Ian!
Regards,
Jim
prev parent reply other threads:[~2015-04-16 21:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH v2 0/3] libxl: fd events: Recheck fd events>
2015-04-16 18:23 ` <21807.61130.841852.546321@mariner.uk.xensource.com> Ian Jackson
2015-04-16 18:23 ` [PATCH 1/3] libxl: fd events: Break out libxl__fd_poll_recheck Ian Jackson
2015-04-17 9:01 ` Ian Campbell
2015-04-16 18:23 ` [PATCH 2/3] libxl: fd events: Break out fd_occurs Ian Jackson
2015-04-17 9:02 ` Ian Campbell
2015-04-17 20:21 ` Konrad Rzeszutek Wilk
2015-04-16 18:23 ` [PATCH 3/3] libxl: fd events: Suppress spurious fd events Ian Jackson
2015-04-17 9:17 ` Ian Campbell
2015-04-16 18:24 ` [PATCH v2 0/3] libxl: fd events: Recheck with poll Ian Jackson
2015-04-17 20:25 ` Konrad Rzeszutek Wilk
2015-04-22 14:23 ` Ian Campbell
2015-04-16 21:19 ` Jim Fehlig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5530275F.4040902@suse.com \
--to=jfehlig@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.