Re: [PATCH 5/6] mmu: gf100: share most of functions with GK20A

[Vince Hsu <vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 04/17/2015 02:27 PM, Alexandre Courbot wrote:
>> -static int
>> >+int
>> >  gf100_vm_create(struct nvkm_mmu *mmu, u64 offset, u64 length, u64 mm_offset,
>> >                 struct nvkm_vm **pvm)
>> >  {
>> >diff --git a/drm/nouveau/nvkm/subdev/mmu/gf100.h b/drm/nouveau/nvkm/subdev/mmu/gf100.h
>> >new file mode 100644
>> >index 000000000000..a66ca45bc755
>> >--- /dev/null
>> >+++ b/drm/nouveau/nvkm/subdev/mmu/gf100.h
>> >@@ -0,0 +1,46 @@
>> >+#ifndef __GF100_MMU_PRIV__
>> >+#define __GF100_MMU_PRIV__
>> >+
>> >+#include <subdev/mmu.h>
>> >+
>> >+struct nv04_mmu_priv {
>> >+       struct nvkm_mmu base;
>> >+       struct nvkm_vm *vm;
>> >+       dma_addr_t null;
>> >+       void *nullp;
>> >+};
> This structure is already declared in nv04.h - it looks wrong to
> re-declare it here, especially since it seems to be unused in all your
> code?
>
I don't why this structure shows here, either. It must be my copy-paste 
error. Sorry. :P

Thanks,
Vince


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau