From: m@bjorling.me (Matias Bjørling)
Subject: [PATCH 1/5 v2] blk-mq: Add prep/unprep support
Date: Fri, 17 Apr 2015 10:15:46 +0200 [thread overview]
Message-ID: <5530C132.30107@bjorling.me> (raw)
In-Reply-To: <20150417063439.GB389@infradead.org>
On 04/17/2015 08:34 AM, Christoph Hellwig wrote:
> On Wed, Apr 15, 2015@02:34:40PM +0200, Matias Bj??rling wrote:
>> Allow users to hook into prep/unprep functions just before an IO is
>> dispatched to the device driver. This is necessary for request-based
>> logic to take place at upper layers.
>
> I don't think any of this logic belongs into the block layer. All this
> should be library functions called by the drivers.
>
Just the prep/unprep, or other pieces as well?
I like that struct request_queue has a ref to struct nvm_dev, and the
variables in request and bio to get to the struct is in the block layer.
In the future, applications can have an API to get/put flash block
directly. (using the blk_nvm_[get/put]_blk interface).
WARNING: multiple messages have this Message-ID (diff)
From: "Matias Bjørling" <m@bjorling.me>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@fb.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
keith.busch@intel.com, javier@paletta.io
Subject: Re: [PATCH 1/5 v2] blk-mq: Add prep/unprep support
Date: Fri, 17 Apr 2015 10:15:46 +0200 [thread overview]
Message-ID: <5530C132.30107@bjorling.me> (raw)
In-Reply-To: <20150417063439.GB389@infradead.org>
On 04/17/2015 08:34 AM, Christoph Hellwig wrote:
> On Wed, Apr 15, 2015 at 02:34:40PM +0200, Matias Bj??rling wrote:
>> Allow users to hook into prep/unprep functions just before an IO is
>> dispatched to the device driver. This is necessary for request-based
>> logic to take place at upper layers.
>
> I don't think any of this logic belongs into the block layer. All this
> should be library functions called by the drivers.
>
Just the prep/unprep, or other pieces as well?
I like that struct request_queue has a ref to struct nvm_dev, and the
variables in request and bio to get to the struct is in the block layer.
In the future, applications can have an API to get/put flash block
directly. (using the blk_nvm_[get/put]_blk interface).
next prev parent reply other threads:[~2015-04-17 8:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 12:34 [PATCH 0/5 v2] Support for Open-Channel SSDs Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-15 12:34 ` [PATCH 1/5 v2] blk-mq: Add prep/unprep support Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-17 6:34 ` Christoph Hellwig
2015-04-17 6:34 ` Christoph Hellwig
2015-04-17 8:15 ` Matias Bjørling [this message]
2015-04-17 8:15 ` Matias Bjørling
2015-04-17 17:46 ` Christoph Hellwig
2015-04-17 17:46 ` Christoph Hellwig
2015-04-18 6:45 ` Matias Bjorling
2015-04-18 6:45 ` Matias Bjorling
2015-04-18 20:16 ` Christoph Hellwig
2015-04-18 20:16 ` Christoph Hellwig
2015-04-19 18:12 ` Matias Bjorling
2015-04-19 18:12 ` Matias Bjorling
2015-04-15 12:34 ` [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-16 9:10 ` Paul Bolle
2015-04-16 9:10 ` Paul Bolle
2015-04-16 10:23 ` Matias Bjørling
2015-04-16 10:23 ` Matias Bjørling
2015-04-16 10:23 ` Matias Bjørling
2015-04-16 11:34 ` Paul Bolle
2015-04-16 11:34 ` Paul Bolle
2015-04-16 11:34 ` Paul Bolle
2015-04-16 13:29 ` Matias Bjørling
2015-04-16 13:29 ` Matias Bjørling
2015-04-16 13:29 ` Matias Bjørling
2015-04-15 12:34 ` [PATCH 3/5 v2] lightnvm: RRPC target Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-16 9:12 ` Paul Bolle
2015-04-16 9:12 ` Paul Bolle
2015-04-15 12:34 ` [PATCH 4/5 v2] null_blk: LightNVM support Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-15 12:34 ` [PATCH 5/5 v2] nvme: " Matias Bjørling
2015-04-15 12:34 ` Matias Bjørling
2015-04-16 14:55 ` Keith Busch
2015-04-16 14:55 ` Keith Busch
2015-04-16 15:14 ` Javier González
2015-04-16 15:14 ` Javier González
2015-04-16 15:52 ` Keith Busch
2015-04-16 15:52 ` Keith Busch
2015-04-16 16:01 ` James R. Bergsten
2015-04-16 16:01 ` James R. Bergsten
2015-04-16 16:01 ` James R. Bergsten
2015-04-16 16:12 ` Keith Busch
2015-04-16 16:12 ` Keith Busch
2015-04-16 17:17 ` Matias Bjorling
2015-04-16 17:17 ` Matias Bjorling
2015-04-16 17:17 ` Matias Bjorling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5530C132.30107@bjorling.me \
--to=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.