Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On 04/17/2015 06:13 AM, Bohdan Trach wrote:
> From: Bohdan Trach <bohdan.trach@mailbox.tu-dresden.de>
> 
> dump-pc-mem command is added for checkpointing guest memory to
> file. Only system RAM region is saved. This checkpoint is later used to
> recover unchanged pages.
> 
> Signed-off-by: Bohdan Trach <bohdan.trach@mailbox.tu-dresden.de>
> ---

> 
> +void qmp_dump_pc_ram(const char *file, Error **errp) {
> +
> +    int rc;
> +    int fd;
> +    fd = open(file,

Please use qemu_open() rather than raw open(), so that your command
automatically supports /dev/fdset/nnn notation for reusing a file
descriptor passed in via SCM_RIGHTS.

> +++ b/qapi-schema.json
> @@ -3648,3 +3648,14 @@
>  # Since: 2.1
>  ##
>  { 'command': 'rtc-reset-reinjection' }
> +
> +##
> +# @dump-pc-ram:
> +#
> +# Checkpoints guest.

The whole guest, or just guest memory?

> +#
> +# @file: the file to save the memory to as binary data
> +#
> +# Returns: Nothing on success

Missing a 'Since: 2.4' designation.

> +##
> +{ 'command': 'dump-pc-ram', 'data': {'file': 'str'} }


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]