Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing

[Bohdan Trach <bohdan.trach@mailbox.tu-dresden.de>]

Thank You for the review.

Please see comments inline.

On 04/17/2015 03:53 PM, Eric Blake wrote:
> On 04/17/2015 06:13 AM, Bohdan Trach wrote:
>> From: Bohdan Trach <bohdan.trach@mailbox.tu-dresden.de>
>>
>> dump-pc-mem command is added for checkpointing guest memory to
>> file. Only system RAM region is saved. This checkpoint is later used to
>> recover unchanged pages.
>>
>> Signed-off-by: Bohdan Trach <bohdan.trach@mailbox.tu-dresden.de>
>> ---
> 
>>
>> +void qmp_dump_pc_ram(const char *file, Error **errp) {
>> +
>> +    int rc;
>> +    int fd;
>> +    fd = open(file,
> 
> Please use qemu_open() rather than raw open(), so that your command
> automatically supports /dev/fdset/nnn notation for reusing a file
> descriptor passed in via SCM_RIGHTS.
> 

OK, this will be fixed.

>> +++ b/qapi-schema.json
>> @@ -3648,3 +3648,14 @@
>>  # Since: 2.1
>>  ##
>>  { 'command': 'rtc-reset-reinjection' }
>> +
>> +##
>> +# @dump-pc-ram:
>> +#
>> +# Checkpoints guest.
> 
> The whole guest, or just guest memory?
> 

dump-pc-ram command currently writes "pc.ram" MemoryRegion to the
specified file.

>> +#
>> +# @file: the file to save the memory to as binary data
>> +#
>> +# Returns: Nothing on success
> 
> Missing a 'Since: 2.4' designation.
> 

OK, I'll add it.

-- 
With best regards,
Bohdan Trach