Re: [PATCH RFC 2/6] purgatory: No need to sha256 update if ptr->len is zero

From: Pratyush Anand <panand@redhat.com>
To: Geoff Levand <geoff@infradead.org>
Cc: kexec@lists.infradead.org, kexec@lists.fedoraproject.org
Subject: Re: [PATCH RFC 2/6] purgatory: No need to sha256 update if ptr->len is zero
Date: Sat, 18 Apr 2015 04:56:55 +0530	[thread overview]
Message-ID: <553196BF.4080703@redhat.com> (raw)
In-Reply-To: <1429289920.5479.8.camel@infradead.org>

On Friday 17 April 2015 10:28 PM, Geoff Levand wrote:
> On Thu, 2015-04-16 at 22:17 +0530, Pratyush Anand wrote:
>> If ptr->len is zero we do not need to update sha256.
>
> Looks OK.  Did you find this sped things up?

No.. I am working for that..

Speed is good when sha256 is prepared in update_purgatory..just a sec..
while it is 2 min during verification..

one diff is that purgatory is using byte copy in memcpy while kexec had 
generic memcpy which has byte/word/page copy features.

But, Most likely speed is low because dcache is disabled.
So I am working to enable d-cache and identity mapped mmu table for 
crashdump regions in purgatory.

~Pratyush

>
> Acked-by: Geoff Levand <geoff@infradead.org>
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec