Re: [PATCH 4/5] iio: adc: xilinx: Fix VREFN sign

[Jonathan Cameron <jic23@kernel.org>]

On 15/04/15 20:11, Thomas Betker wrote:
> From: Thomas Betker <thomas.betker@rohde-schwarz.com>
> 
> The VREFN channel is bipolar, not unipolar. Small negative values do
> occur (e.g., -1mV), and unsigned conversion maps them incorrectly to
> large positive values (about +1V), so fix this.
> 
> Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>
Applied to the fixes-togreg branch of iio.git. Marked for stable.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/xilinx-xadc-core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 6fa629b..ce93bd8 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -997,7 +997,7 @@ static const struct iio_event_spec xadc_voltage_events[] = {
>  	.num_event_specs = (_alarm) ? ARRAY_SIZE(xadc_voltage_events) : 0, \
>  	.scan_index = (_scan_index), \
>  	.scan_type = { \
> -		.sign = 'u', \
> +		.sign = ((_addr) == XADC_REG_VREFN) ? 's' : 'u', \
>  		.realbits = 12, \
>  		.storagebits = 16, \
>  		.shift = 4, \
>