From: Hartmut Knaack <knaack.h@gmx.de>
To: Thomas Betker <thomas.betker@freenet.de>, linux-iio@vger.kernel.org
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Thomas Betker" <thomas.betker@rohde-schwarz.com>
Subject: Re: [PATCH 3/5] iio: adc: xilinx: Fix VREFP scale
Date: Fri, 26 Jun 2015 23:55:47 +0200 [thread overview]
Message-ID: <558DCA63.6040001@gmx.de> (raw)
In-Reply-To: <1429125111-2926-4-git-send-email-thomas.betker@freenet.de>
Thomas Betker schrieb am 15.04.2015 um 21:11:
> From: Thomas Betker <thomas.betker@rohde-schwarz.com>
>
> The scaling factor for VREFP is 3.0/4096, not 1.0/4096; fix this to get
> correct readings.
>
Hi Thomas,
I just had a look at the datasheet [1], table 3-1 on page 37, and get the feeling
that this scaling factor also applies to the VREFN channel. What is your opinion?
Thanks,
Hartmut
[1] http://www.xilinx.com/support/documentation/user_guides/ug480_7Series_XADC.pdf
> Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 0ad7b50..6fa629b 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -856,6 +856,7 @@ static int xadc_read_raw(struct iio_dev *indio_dev,
> switch (chan->address) {
> case XADC_REG_VCCINT:
> case XADC_REG_VCCAUX:
> + case XADC_REG_VREFP:
> case XADC_REG_VCCBRAM:
> case XADC_REG_VCCPINT:
> case XADC_REG_VCCPAUX:
>
next prev parent reply other threads:[~2015-06-26 21:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 19:11 [Patch 0/5] iio: adc: xilinx: Fix some minor issues Thomas Betker
2015-04-15 19:11 ` [PATCH 1/5] iio: adc: xilinx: Fix register addresses Thomas Betker
2015-04-19 12:48 ` Jonathan Cameron
2015-04-15 19:11 ` [PATCH 2/5] iio: adc: xilinx: Fix "vccaux" channel .address Thomas Betker
2015-04-19 12:51 ` Jonathan Cameron
2015-04-15 19:11 ` [PATCH 3/5] iio: adc: xilinx: Fix VREFP scale Thomas Betker
2015-04-19 12:51 ` Jonathan Cameron
2015-06-26 21:55 ` Hartmut Knaack [this message]
2015-06-30 10:56 ` Thomas.Betker
2015-07-01 18:30 ` Hartmut Knaack
2015-07-03 7:52 ` Thomas.Betker
2015-04-15 19:11 ` [PATCH 4/5] iio: adc: xilinx: Fix VREFN sign Thomas Betker
2015-04-19 12:52 ` Jonathan Cameron
2015-04-15 19:11 ` [PATCH 5/5] iio: adc: xilinx: Set .datasheet_name instead of .extend_name Thomas Betker
2015-04-15 20:54 ` [Patch 0/5] iio: adc: xilinx: Fix some minor issues Jonathan Cameron
2015-04-16 6:20 ` Lars-Peter Clausen
2015-04-16 8:03 ` Thomas.Betker
2015-04-16 7:53 ` Thomas.Betker
2015-04-18 19:26 ` Jonathan Cameron
2015-04-20 8:34 ` Thomas.Betker
2015-04-21 19:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558DCA63.6040001@gmx.de \
--to=knaack.h@gmx.de \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
--cc=thomas.betker@freenet.de \
--cc=thomas.betker@rohde-schwarz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.