* [PATCH v2 1/2] MAINTAINERS: add entry for Rockchip drm drivers @ 2015-04-19 22:59 Heiko Stübner 2015-04-19 23:00 ` [PATCH v2 2/2] drm/rockchip: fix error check when getting irq Heiko Stübner 0 siblings, 1 reply; 3+ messages in thread From: Heiko Stübner @ 2015-04-19 22:59 UTC (permalink / raw) To: Mark Yao; +Cc: linux-rockchip, dri-devel Mark Yao looks after the Rockchip drm drivers and should thus also get patches touching these. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7687fc6..7e4d386 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3410,6 +3410,13 @@ F: drivers/gpu/drm/rcar-du/ F: drivers/gpu/drm/shmobile/ F: include/linux/platform_data/shmob_drm.h +DRM DRIVERS FOR ROCKCHIP +M: Mark Yao <mark.yao@rock-chips.com> +L: dri-devel@lists.freedesktop.org +S: Maintained +F: drivers/gpu/drm/rockchip/ +F: Documentation/devicetree/bindings/video/rockchip* + DSBR100 USB FM RADIO DRIVER M: Alexey Klimov <klimov.linux@gmail.com> L: linux-media@vger.kernel.org -- 2.1.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] drm/rockchip: fix error check when getting irq 2015-04-19 22:59 [PATCH v2 1/2] MAINTAINERS: add entry for Rockchip drm drivers Heiko Stübner @ 2015-04-19 23:00 ` Heiko Stübner 2015-04-20 1:33 ` Mark yao 0 siblings, 1 reply; 3+ messages in thread From: Heiko Stübner @ 2015-04-19 23:00 UTC (permalink / raw) To: Mark Yao; +Cc: linux-rockchip, David Binderman, dri-devel platform_get_irq() can return negative error values and we already test for these. Therefore the variable holding this value should be signed to not loose possible error values. Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Reviewed-By: Daniel Kurtz <djkurtz@chromium.org> --- changed since v1: - instead of making irq in struct vop signed use a separate local irq int in vop_bind as suggested by Daniel Kurtz drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index ccb0ce0..0e539d8 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1409,7 +1409,7 @@ static int vop_bind(struct device *dev, struct device *master, void *data) struct vop *vop; struct resource *res; size_t alloc_size; - int ret; + int ret, irq; of_id = of_match_device(vop_driver_dt_match, dev); vop_data = of_id->data; @@ -1445,11 +1445,12 @@ static int vop_bind(struct device *dev, struct device *master, void *data) return ret; } - vop->irq = platform_get_irq(pdev, 0); - if (vop->irq < 0) { + irq = platform_get_irq(pdev, 0); + if (irq < 0) { dev_err(dev, "cannot find irq for vop\n"); - return vop->irq; + return irq; } + vop->irq = (unsigned int)irq; spin_lock_init(&vop->reg_lock); spin_lock_init(&vop->irq_lock); -- 2.1.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] drm/rockchip: fix error check when getting irq 2015-04-19 23:00 ` [PATCH v2 2/2] drm/rockchip: fix error check when getting irq Heiko Stübner @ 2015-04-20 1:33 ` Mark yao 0 siblings, 0 replies; 3+ messages in thread From: Mark yao @ 2015-04-20 1:33 UTC (permalink / raw) To: Heiko Stübner; +Cc: linux-rockchip, David Binderman, dri-devel On 2015年04月20日 07:00, Heiko Stübner wrote: > platform_get_irq() can return negative error values and we already test for > these. Therefore the variable holding this value should be signed to not > loose possible error values. > > Reported-by: David Binderman <dcb314@hotmail.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > Reviewed-By: Daniel Kurtz <djkurtz@chromium.org> > --- > changed since v1: > - instead of making irq in struct vop signed use a > separate local irq int in vop_bind as suggested by Daniel Kurtz > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index ccb0ce0..0e539d8 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1409,7 +1409,7 @@ static int vop_bind(struct device *dev, struct device *master, void *data) > struct vop *vop; > struct resource *res; > size_t alloc_size; > - int ret; > + int ret, irq; > > of_id = of_match_device(vop_driver_dt_match, dev); > vop_data = of_id->data; > @@ -1445,11 +1445,12 @@ static int vop_bind(struct device *dev, struct device *master, void *data) > return ret; > } > > - vop->irq = platform_get_irq(pdev, 0); > - if (vop->irq < 0) { > + irq = platform_get_irq(pdev, 0); > + if (irq < 0) { > dev_err(dev, "cannot find irq for vop\n"); > - return vop->irq; > + return irq; > } > + vop->irq = (unsigned int)irq; > > spin_lock_init(&vop->reg_lock); > spin_lock_init(&vop->irq_lock); Thanks for fix, I have sent the Pull request.:-) -- Ｍark _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-20 1:33 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-04-19 22:59 [PATCH v2 1/2] MAINTAINERS: add entry for Rockchip drm drivers Heiko Stübner 2015-04-19 23:00 ` [PATCH v2 2/2] drm/rockchip: fix error check when getting irq Heiko Stübner 2015-04-20 1:33 ` Mark yao
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.