All of lore.kernel.org
 help / color / mirror / Atom feed
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Date: Tue, 21 Apr 2015 11:02:57 +0530	[thread overview]
Message-ID: <5535E109.3020001@ti.com> (raw)
In-Reply-To: <4138287.C3OjQp3FFm@wuerfel>

Arnd,

On Wednesday 15 April 2015 03:17 AM, Arnd Bergmann wrote:
> On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote:
>>>
>>> [1] ->
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111
>>>
>> Kishon,removing select GENERIC_PHY also breaks the builds for certain
>> architectures (i386 and x84_64). Is the consensus to leave the select
>> but make GENERIC_PHY a invisible option? Thanks
>
> I think the best solution is
>
> - make GENERIC_PHY a silent option
> - change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so
>    it will still work when all other phy drivers are disabled
> - change the non-phy drivers that select GENERIC_PHY to either
>    use 'depends on' or no explicit dependency in case they are
>    still functional without the API. Note that
>    drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well,
>    not a consumer, despite being outside of drivers/phy.

makes sense to me.

Thanks
Kishon

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Arun Ramamurthy <arun.ramamurthy@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	<bcm-kernel-feedback-list@broadcom.com>,
	Thomas Pugliese <thomas.pugliese@gmail.com>,
	Peter Griffin <peter.griffin@linaro.org>,
	Jonathan Richardson <jonathar@broadcom.com>,
	Anatol Pomazau <anatol@google.com>, Ray Jui <rjui@broadcom.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Dmitry Torokhov <dtor@google.com>,
	David Mosberger <davidm@egauge.net>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Kevin Hao <haokexin@gmail.com>, Paul Bolle <pebolle@tiscali.nl>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	Scott Branden <sbranden@broadcom.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>, Tony Prisk <linux@prisktech.co.nz>
Subject: Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Date: Tue, 21 Apr 2015 11:02:57 +0530	[thread overview]
Message-ID: <5535E109.3020001@ti.com> (raw)
In-Reply-To: <4138287.C3OjQp3FFm@wuerfel>

Arnd,

On Wednesday 15 April 2015 03:17 AM, Arnd Bergmann wrote:
> On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote:
>>>
>>> [1] ->
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111
>>>
>> Kishon,removing select GENERIC_PHY also breaks the builds for certain
>> architectures (i386 and x84_64). Is the consensus to leave the select
>> but make GENERIC_PHY a invisible option? Thanks
>
> I think the best solution is
>
> - make GENERIC_PHY a silent option
> - change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so
>    it will still work when all other phy drivers are disabled
> - change the non-phy drivers that select GENERIC_PHY to either
>    use 'depends on' or no explicit dependency in case they are
>    still functional without the API. Note that
>    drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well,
>    not a consumer, despite being outside of drivers/phy.

makes sense to me.

Thanks
Kishon

  reply	other threads:[~2015-04-21  5:32 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 22:10 [PATCHv2 0/3] Add devm_of_phy_get_by_index and update platform drivers Arun Ramamurthy
2015-04-13 22:10 ` Arun Ramamurthy
2015-04-13 22:10 ` [PATCHv2 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core Arun Ramamurthy
2015-04-13 22:10   ` Arun Ramamurthy
2015-04-15  9:59   ` Kishon Vijay Abraham I
2015-04-15  9:59     ` Kishon Vijay Abraham I
2015-04-20 20:19     ` Arun Ramamurthy
2015-04-20 20:19       ` Arun Ramamurthy
2015-04-21  5:37       ` Kishon Vijay Abraham I
2015-04-21  5:37         ` Kishon Vijay Abraham I
2015-04-16  7:08   ` Peter Chen
2015-04-16  7:08     ` Peter Chen
2015-04-13 22:10 ` [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index Arun Ramamurthy
2015-04-13 22:10   ` Arun Ramamurthy
2015-04-14 11:19   ` Greg Kroah-Hartman
2015-04-14 11:19     ` Greg Kroah-Hartman
2015-04-14 11:33     ` Arnd Bergmann
2015-04-14 11:33       ` Arnd Bergmann
2015-04-14 12:37       ` Greg Kroah-Hartman
2015-04-14 12:37         ` Greg Kroah-Hartman
2015-04-14 13:17         ` Arnd Bergmann
2015-04-14 13:17           ` Arnd Bergmann
2015-04-14 13:27           ` Greg Kroah-Hartman
2015-04-14 13:27             ` Greg Kroah-Hartman
2015-04-14 14:21             ` Kishon Vijay Abraham I
2015-04-14 14:21               ` Kishon Vijay Abraham I
2015-04-14 18:05               ` Arun Ramamurthy
2015-04-14 18:05                 ` Arun Ramamurthy
2015-04-14 21:47                 ` Arnd Bergmann
2015-04-14 21:47                   ` Arnd Bergmann
2015-04-21  5:32                   ` Kishon Vijay Abraham I [this message]
2015-04-21  5:32                     ` Kishon Vijay Abraham I
2015-04-14 14:23           ` Kishon Vijay Abraham I
2015-04-14 14:23             ` Kishon Vijay Abraham I
2015-04-14 14:41   ` Alan Stern
2015-04-14 14:41     ` Alan Stern
2015-04-14 17:54     ` Arun Ramamurthy
2015-04-14 17:54       ` Arun Ramamurthy
2015-04-15  9:57   ` rajeev kumar
2015-04-15  9:57     ` rajeev kumar
2015-04-15 14:36     ` Alan Stern
2015-04-15 14:36       ` Alan Stern
2015-04-16  4:55       ` rajeev kumar
2015-04-16  4:55         ` rajeev kumar
2015-04-13 22:10 ` [PATCHv2 3/3] usb: ohci-platform: " Arun Ramamurthy
2015-04-13 22:10   ` Arun Ramamurthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5535E109.3020001@ti.com \
    --to=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.