All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	lgirdwood@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] regulator: max8973: make default/unset dvs gpio as invalid gpio
Date: Tue, 21 Apr 2015 18:45:24 +0530	[thread overview]
Message-ID: <55364D6C.4090702@nvidia.com> (raw)
In-Reply-To: <20150420211514.GO14892@sirena.org.uk>


On Tuesday 21 April 2015 02:45 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, Apr 20, 2015 at 06:24:16PM +0530, Laxman Dewangan wrote:
>> If platform data has dvs-gpio value 0 as default/unset then
>> make this as invalid gpio so that function gpio_is_valid()
>> can return false on this case.
> OK, so this handles the problem with the first patch - it should have
> been the first patch to help with review.
>
Yaah, I realized after reading your comment on patch 1 that I should 
have on different sequence.

Thanks for accepting the patches.

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
	<lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] regulator: max8973: make default/unset dvs gpio as invalid gpio
Date: Tue, 21 Apr 2015 18:45:24 +0530	[thread overview]
Message-ID: <55364D6C.4090702@nvidia.com> (raw)
In-Reply-To: <20150420211514.GO14892@sirena.org.uk>


On Tuesday 21 April 2015 02:45 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, Apr 20, 2015 at 06:24:16PM +0530, Laxman Dewangan wrote:
>> If platform data has dvs-gpio value 0 as default/unset then
>> make this as invalid gpio so that function gpio_is_valid()
>> can return false on this case.
> OK, so this handles the problem with the first patch - it should have
> been the first patch to help with review.
>
Yaah, I realized after reading your comment on patch 1 that I should 
have on different sequence.

Thanks for accepting the patches.

  reply	other threads:[~2015-04-21 13:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 12:54 [PATCH 0/3] regulator: max8973: cleanups and add DT parsing for platform data Laxman Dewangan
2015-04-20 12:54 ` Laxman Dewangan
2015-04-20 12:54 ` [PATCH 1/3] regulator: max8973: get rid of extra variable for gpio validity Laxman Dewangan
2015-04-20 12:54   ` Laxman Dewangan
2015-04-20 15:06   ` Mark Brown
2015-04-20 21:19   ` Mark Brown
2015-05-06 12:09     ` Laxman Dewangan
2015-05-06 12:09       ` Laxman Dewangan
     [not found]       ` <554A0478.6070007-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-05-06 12:34         ` Mark Brown
2015-05-06 12:34           ` Mark Brown
     [not found] ` <1429534457-15515-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-04-20 12:54   ` [PATCH 2/3] regulator: max8973: make default/unset dvs gpio as invalid gpio Laxman Dewangan
2015-04-20 12:54     ` Laxman Dewangan
     [not found]     ` <1429534457-15515-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-04-20 21:15       ` Mark Brown
2015-04-20 21:15         ` Mark Brown
2015-04-21 13:15         ` Laxman Dewangan [this message]
2015-04-21 13:15           ` Laxman Dewangan
2015-04-20 21:19     ` Mark Brown
2015-04-20 12:54 ` [PATCH 3/3] regulator: max8973: add DT parsing of platform specific parameter Laxman Dewangan
2015-04-20 12:54   ` Laxman Dewangan
2015-04-20 21:19   ` Mark Brown
     [not found]     ` <20150420211907.GP14892-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-21 14:15       ` Laxman Dewangan
2015-04-21 14:15         ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55364D6C.4090702@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.