[PATCH bpf-next] selftests/bpf: fix unintentional switch case fall through

[PATCH bpf-next] selftests/bpf: fix unintentional switch case fall through

[Mykyta Yatsenko]

From: Mykyta Yatsenko <yatsenko@meta.com>

Break from switch expression after parsing -n CLI argument in veristat,
instead of falling through and enabling comparison mode.
Fixes: a5c57f81eb2b ("veristat: add ability to set BPF_F_TEST_SANITY_STRICT flag with -r flag")

Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
---
 tools/testing/selftests/bpf/veristat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
index 56771650ee8c..4da627ca5749 100644
--- a/tools/testing/selftests/bpf/veristat.c
+++ b/tools/testing/selftests/bpf/veristat.c
@@ -364,6 +364,7 @@ static error_t parse_arg(int key, char *arg, struct argp_state *state)
 			fprintf(stderr, "invalid top N specifier: %s\n", arg);
 			argp_usage(state);
 		}
+		break;
 	case 'C':
 		env.comparison_mode = true;
 		break;
-- 
2.49.0

Re: [PATCH bpf-next] selftests/bpf: fix unintentional switch case fall through

[Yonghong Song]

On 6/17/25 5:15 AM, Mykyta Yatsenko wrote:
> From: Mykyta Yatsenko <yatsenko@meta.com>
>
> Break from switch expression after parsing -n CLI argument in veristat,
> instead of falling through and enabling comparison mode.
> Fixes: a5c57f81eb2b ("veristat: add ability to set BPF_F_TEST_SANITY_STRICT flag with -r flag")
>
> Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>

Acked-by: Yonghong Song <yonghong.song@linux.dev>

Re: [PATCH bpf-next] selftests/bpf: fix unintentional switch case fall through

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Tue, 17 Jun 2025 13:15:36 +0100 you wrote:
> From: Mykyta Yatsenko <yatsenko@meta.com>
> 
> Break from switch expression after parsing -n CLI argument in veristat,
> instead of falling through and enabling comparison mode.
> Fixes: a5c57f81eb2b ("veristat: add ability to set BPF_F_TEST_SANITY_STRICT flag with -r flag")
> 
> Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: fix unintentional switch case fall through
    https://git.kernel.org/bpf/bpf-next/c/66ab68c9de89

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html