Re: [PATCH] omap: i2c: Add calls for pinctrl state select

[Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hey Wolfram,

On 22.04.2015 10:12, Wolfram Sang wrote:
> On Fri, Apr 17, 2015 at 05:07:57PM +0200, pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> From: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> This adds calls to pinctrl subsystem in order to switch pin states
>> on suspend/resume if you provide a "sleep" state in DT.
>>
>> Signed-off-by: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> ? Don't you get a build error? I do. Rightfully, I'd think, there is no
> pinctrl-include.

You are right, the include is missing. I just reapplied the patch,
compiled and interestingly enough, I don't get any compile errors. (?)
Some further checks revealed, that the include is also missing in
drivers/i2c/busses/i2c-st.c - which I used to get the idea on how to use
these calls.

I'm using a buildroot toolchain:
gcc version 4.9.2 (Buildroot 2014.11-00023-g60d7a19-dirty)

Do you have any idea on where these differences are coming from?

In any case, the include belongs there, so I will resend that patch.

regards
pascal